Summary: | [WebKitTestRunner] setOpenPanelFiles support in non-local tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
Component: | Tools / Tests | Assignee: | Lauro Moura <lmoura> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes, clopez, commit-queue, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Lauro Moura
2020-01-20 20:30:16 PST
Created attachment 388276 [details]
Tentative patch
Tentative patch by treating paths passed to setOpenPanelFiles with leading slash as absolute file:// paths.
EWS failures: * win: fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html * Flaky, failing from time to time with unrelated patches * https://ews-build.webkit.org/#/builders/10 * mac-wk2: inspector/heap/getRemoteObject.html * Ditto * https://ews-build.webkit.org/#/builders/31 * api-ios: KeyboardInputTests.SupportsImagePaste * Ditto * https://ews-build.webkit.org/#/builders/9 * api-mac: WebAuthenticationPanel.PanelHidCtapNoCredentialsFound * Ditto * https://ews-build.webkit.org/#/builders/3 cc'ing Andy and Tim (original author and reviewer) for review. Comment on attachment 388276 [details]
Tentative patch
Does this patch fixes any test? Then I think this patch should also unlist the failures it fixes from the TestExpectation
Created attachment 389284 [details]
Patch
(In reply to Carlos Alberto Lopez Perez from comment #4) > Comment on attachment 388276 [details] > Tentative patch > > Does this patch fixes any test? Then I think this patch should also unlist > the failures it fixes from the TestExpectation Right, updated with the new expectations. The redirect test is still failing despite loading the correct data, so I opened a bug for it in bug207016. The commit-queue encountered the following flaky tests while processing attachment 389284 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 389284 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 389284 [details] Patch Clearing flags on attachment: 389284 Committed r255590: <https://trac.webkit.org/changeset/255590> All reviewed patches have been landed. Closing bug. |