Bug 206456

Summary: Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch beidson: review+

Alex Christensen
Reported 2020-01-17 15:57:50 PST
Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
Attachments
Patch (6.81 KB, patch)
2020-01-17 16:00 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.31 KB, patch)
2020-02-26 17:33 PST, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-01-17 16:00:15 PST
Created attachment 388105 [details] Patch
youenn fablet
Comment 2 2020-01-30 00:21:22 PST
Some related API tests seem to fail.
Alex Christensen
Comment 3 2020-02-26 17:33:22 PST
Created attachment 391820 [details] Patch
Brady Eidson
Comment 4 2020-02-26 20:32:59 PST
Comment on attachment 391820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391820&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:346 > - return _websiteDataStore->sourceApplicationBundleIdentifier(); > + return nil; Why leave this here at all? > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:351 > - (void)_setSourceApplicationBundleIdentifier:(NSString *)identifier > { > - if (!_websiteDataStore->setSourceApplicationBundleIdentifier(identifier)) > - [NSException raise:NSGenericException format:@"_setSourceApplicationBundleIdentifier cannot be called after networking has begun"]; > } Ditto
Alex Christensen
Comment 5 2020-02-26 20:44:29 PST
Gone! http://trac.webkit.org/r257553
Radar WebKit Bug Importer
Comment 6 2020-02-26 20:45:16 PST
<rdar://problem/59834364>
Note You need to log in before you can comment on or make changes to this bug.