Bug 206451

Summary: Remove std::lock_guard
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cgarcia, cmarcelo, commit-queue, darin, eric.carlson, ews-watchlist, fred.wang, ggaren, glenn, hi, hta, jamesr, jbedard, jer.noble, jiewen_tan, joepeck, keith_miller, luiz, mark.lam, mmaxfield, msaboff, philipj, saam, sergio, tommyw, tonikitoo, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206443
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Basuke Suzuki
Reported 2020-01-17 15:31:42 PST
We are on C++ 17. https://en.cppreference.com/w/cpp/thread/scoped_lock
Attachments
Patch (76.30 KB, patch)
2020-02-29 02:00 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (80.08 KB, patch)
2020-02-29 02:13 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (80.23 KB, patch)
2020-02-29 02:41 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-01-17 15:47:32 PST
https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement Our requirement is GCC7. So, we can use it. https://www.gnu.org/software/gcc/gcc-7/changes.html
Basuke Suzuki
Comment 2 2020-01-17 16:39:14 PST
It generates exactly same code. We can safely replace this. https://godbolt.org/z/p-KTwc
Yusuke Suzuki
Comment 3 2020-02-29 02:00:17 PST
Created attachment 392054 [details] Patch
Yusuke Suzuki
Comment 4 2020-02-29 02:13:41 PST
Created attachment 392055 [details] Patch
Yusuke Suzuki
Comment 5 2020-02-29 02:41:48 PST
Created attachment 392057 [details] Patch
Anders Carlsson
Comment 6 2020-02-29 07:02:41 PST
Comment on attachment 392057 [details] Patch OK.
Yusuke Suzuki
Comment 7 2020-02-29 20:13:35 PST
Comment on attachment 392057 [details] Patch Thanks
WebKit Commit Bot
Comment 8 2020-02-29 21:01:37 PST
Comment on attachment 392057 [details] Patch Clearing flags on attachment: 392057 Committed r257688: <https://trac.webkit.org/changeset/257688>
WebKit Commit Bot
Comment 9 2020-02-29 21:01:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-02-29 21:02:17 PST
<rdar://problem/59925404>
Note You need to log in before you can comment on or make changes to this bug.