| Summary: | Drop dead code related to local storage prewarming | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, dbates, ews-watchlist, ggaren, japhet, sam, sihui_liu, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=200373 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-01-17 08:52:17 PST
Created attachment 388044 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 388044 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 388044 [details] Patch Clearing flags on attachment: 388044 Committed r254753: <https://trac.webkit.org/changeset/254753> All reviewed patches have been landed. Closing bug. It's not dead... My change was about the prewarm message. By creating localStorage ahead, web process connects to the storage area in network process, and network process does the prewarm there. (In reply to Sihui Liu from comment #6) > It's not dead... My change was about the prewarm message. By creating > localStorage ahead, web process connects to the storage area in network > process, and network process does the prewarm there. Ok, I will revert but add a comment then. It is too subtle otherwise. Reverted r254753 for reason: It turns out this is not dead code Committed r254857: <https://trac.webkit.org/changeset/254857> |