Bug 20639

Summary:	ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
Product:	WebKit	Reporter:	Eric Seidel (no email) <eric>
Component:	New Bugs	Assignee:	Eric Seidel (no email) <eric>
Status:	RESOLVED FIXED
Severity:	Normal
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Mac
OS:	OS X 10.5

Eric Seidel (no email)

Reported 2008-09-03 22:33:24 PDT

ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE I made i one as part of various Platform.h cleanup in: http://trac.webkit.org/changeset/36074 Mark fixed it to actually work in: http://trac.webkit.org/changeset/36076 http://trac.webkit.org/changeset/36078 It doesn't need to be a FEATURE_DEFINE, since it only works for Mac. it can still be a separate ifdef though, but Platform.h can just turn it on for Apple-Mac only (once we have a way to distinguish Apple's Mac port from any other Mac port).

Attachments
Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2008-09-03 23:15:04 PDT

After r36074 we have ENABLE_DASHBOARD_SUPPORT sprinkled over many files. It's not a "feature" like the other items listed in FEATURE_DEFINES, so it should be removed from there ASAP.

Mark Rowe (bdash)

Comment 2 2008-09-04 14:44:40 PDT

Fixed in r36102.

Note You need to log in before you can comment on or make changes to this bug.