Bug 206384

Summary: Use the same AccessibilityObjectWrapper for associated AXObject and AXIsolatedObject.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, annulen, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, ryuan.choi, samuel_white, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Uploading diff manually.
none
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2020-01-16 16:22:20 PST
Use the same AccessibilityObjectWrapper for associated AXObject and AXIsolatedObject.
Attachments
Patch (253.39 KB, patch)
2020-01-16 17:01 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Uploading diff manually. (29.79 KB, patch)
2020-01-16 17:48 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (219.33 KB, patch)
2020-01-23 09:41 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (219.40 KB, patch)
2020-01-23 11:55 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (219.54 KB, patch)
2020-01-23 16:58 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-01-16 17:01:46 PST
Created attachment 387992 [details] Patch
Andres Gonzalez
Comment 2 2020-01-16 17:48:04 PST
Created attachment 387997 [details] Uploading diff manually.
Andres Gonzalez
Comment 3 2020-01-23 09:41:22 PST
Created attachment 388555 [details] Patch
chris fleizach
Comment 4 2020-01-23 09:50:32 PST
Comment on attachment 388555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388555&action=review > Source/WebCore/accessibility/AXObjectCache.h:176 > + void cacheAndInitializeWrapper(AccessibilityObject*, RenderObject* = nullptr, Node* = nullptr, Widget* = nullptr); don't know if this feasible, but would it be possible to templatize the "other" object (RenderObject/Node/Widget) so that there was only one parameter? > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:354 > + if (!isMainThread()) should we add something like if (!clientSupportsIsolatedTree()) ASSERT_NOT_REACHED()
Andres Gonzalez
Comment 5 2020-01-23 11:55:56 PST
Created attachment 388571 [details] Patch
Andres Gonzalez
Comment 6 2020-01-23 16:58:35 PST
Created attachment 388620 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-23 17:48:36 PST
Comment on attachment 388620 [details] Patch Clearing flags on attachment: 388620 Committed r255044: <https://trac.webkit.org/changeset/255044>
WebKit Commit Bot
Comment 8 2020-01-23 17:48:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-23 17:49:14 PST
<rdar://problem/58855851>
Note You need to log in before you can comment on or make changes to this bug.