| Summary: | Rename SelectionData classes and structures HighlightData, etc to be more inclusive for their new use cases | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | annulen, commit-queue, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mifenton, mmaxfield, pdr, rniwa, ryuan.choi, sabouhallawa, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Megan Gardner
2020-01-16 01:26:16 PST
Created attachment 387898 [details]
Patch
Created attachment 387923 [details]
Patch
Comment on attachment 387923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387923&action=review r=me provided the following issues are addressed. > Source/WebCore/rendering/HighlightData.cpp:48 > +struct SelectionData { I guess you're gonna rename this in a followup? > Source/WebCore/rendering/RenderObject.h:696 > + enum HighlightState { Please use enum class instead. We then don't have to prefix every value with "Highlight". Also specify the width: uint8_t. > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:60 > - BuildableName = "libANGLE-shared.dylib" > + BuildableName = "libANGLE.a" revert? Created attachment 388470 [details]
Patch
Is this new patch still up for a review?? I guess I hadn't actually pushed it, I was going to, but my connection to my work computer stopped functioning and completely distracted me. Did you have more comments? Created attachment 390261 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 390261 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 390261 [details] Patch for landing Clearing flags on attachment: 390261 Committed r256196: <https://trac.webkit.org/changeset/256196> All reviewed patches have been landed. Closing bug. |