Bug 206339

Summary: operationToObject() should check for a null errorMessage.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2020-01-15 23:31:01 PST
r224280 introduced operationToObject() with an option to specify a custom error message. r254252 added a scenario where the passed in error message is null but did not fix operationToObject() to allow for this. We should add the missing null check. <rdar://problem/58449666>
Attachments
proposed patch. (2.57 KB, patch)
2020-01-15 23:35 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-01-15 23:35:38 PST
Created attachment 387897 [details] proposed patch.
Yusuke Suzuki
Comment 2 2020-01-15 23:37:59 PST
Comment on attachment 387897 [details] proposed patch. r=me
Mark Lam
Comment 3 2020-01-16 09:26:55 PST
Thanks for the review. Landed in r254687: <http://trac.webkit.org/r254687>.
Note You need to log in before you can comment on or make changes to this bug.