Bug 206339

Summary:

operationToObject() should check for a null errorMessage.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	ysuzuki: review+

Description Mark Lam 2020-01-15 23:31:01 PST

r224280 introduced operationToObject() with an option to specify a custom error message.  r254252 added a scenario where the passed in error message is null but did not fix operationToObject() to allow for this.  We should add the missing null check.

<rdar://problem/58449666>

Comment 1 Mark Lam 2020-01-15 23:35:38 PST

Created attachment 387897 [details]
proposed patch.

Comment 2 Yusuke Suzuki 2020-01-15 23:37:59 PST

Comment on attachment 387897 [details]
proposed patch.

r=me

Comment 3 Mark Lam 2020-01-16 09:26:55 PST

Thanks for the review.  Landed in r254687: <http://trac.webkit.org/r254687>.