| Summary: | Update ANGLE | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||
| Component: | ANGLE | Assignee: | James Darpinian <jdarpinian> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, dino, eric.carlson, ews-watchlist, glenn, graouts, gyuyoung.kim, jer.noble, kbr, kondapallykalyan, mcatanzaro, philipj, ryuan.choi, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=205483 https://bugs.webkit.org/show_bug.cgi?id=198948 |
||||||||||
| Bug Depends on: | 207080 | ||||||||||
| Bug Blocks: | 198948, 205483, 206625 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
James Darpinian
2020-01-15 15:14:29 PST
Created attachment 387857 [details]
Update ANGLE
Created attachment 387866 [details]
rebase
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE I will land in a moment. Committed r254981: <https://trac.webkit.org/changeset/254981> Committed r255403: <https://trac.webkit.org/changeset/255403> Reverted again in r255410 due to continuing test failures. I have found the root cause in bug 207080. Created attachment 389707 [details]
Update ANGLE again
Comment on attachment 389707 [details]
Update ANGLE again
rs=me
I will land now.
Committed r255782: <https://trac.webkit.org/changeset/255782> (In reply to Build Bot from comment #3) > Note that there are important steps to take when updating ANGLE. See > http://trac.webkit.org/wiki/UpdatingANGLE Looks like some steps from this wiki page are obsolete? Steps 3 through 6? OK for me to remove those from the wiki page? I'll also add a step mentioning the need to maintain changes.diff. Yes, please do update the wiki, I don't have permission. All of the steps there are obsolete. The steps now are: 1. Run the script Source/ThirdParty/update-angle.sh and follow its instructions. That's it. The script does a git rebase which automatically carries forward all existing modifications such as the license disclaimer mentioned in the old steps. It handles updating the plist file and the changes.diff file and even the CMake files, and it gives instructions for how to modify the XCode build. There are no other manual steps anymore. Sorry, the actual path to the script is Source/ThirdParty/ANGLE/update-angle.sh OK thanks, new wiki page: https://trac.webkit.org/wiki/UpdatingANGLE |