Bug 206299

Summary: [Win] Fix AppleWin build
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2020-01-15 10:59:20 PST 
Fix compile errors in internal AppleWin build.
Comment 1 Per Arne Vollan 2020-01-15 17:12:20 PST 
Created attachment 387872 [details]
Patch
Comment 2 Brent Fulgham 2020-01-15 17:27:38 PST 
Comment on attachment 387872 [details]
Patch

Looks good. r=me.
Comment 3 Don Olmstead 2020-01-15 17:33:18 PST 
Looks good to me as well just wondering if we want to have the target files in a target directory.
Comment 4 Per Arne Vollan 2020-01-15 19:47:03 PST 
Created attachment 387889 [details]
Patch
Comment 5 Per Arne Vollan 2020-01-15 19:47:42 PST 
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 387872 [details]
> Patch
> 
> Looks good. r=me.

Thanks for reviewing!
Comment 6 Per Arne Vollan 2020-01-15 19:48:01 PST 
(In reply to Don Olmstead from comment #3)
> Looks good to me as well just wondering if we want to have the target files
> in a target directory.

Fixed.

Thanks for reviewing!
Comment 7 Per Arne Vollan 2020-01-15 19:49:02 PST 
rdar://problem/58379794
Comment 8 WebKit Commit Bot 2020-01-16 07:57:01 PST 
Comment on attachment 387889 [details]
Patch

Clearing flags on attachment: 387889

Committed r254681: <https://trac.webkit.org/changeset/254681>
Comment 9 WebKit Commit Bot 2020-01-16 07:57:04 PST 
All reviewed patches have been landed.  Closing bug.