Bug 206299

Summary: [Win] Fix AppleWin build
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, don.olmstead, ews-watchlist, fujii.hironori, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Per Arne Vollan
Reported 2020-01-15 10:59:20 PST
Fix compile errors in internal AppleWin build.
Attachments
Patch (9.32 KB, patch)
2020-01-15 17:12 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (12.81 KB, patch)
2020-01-15 19:47 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-01-15 17:12:20 PST
Created attachment 387872 [details] Patch
Brent Fulgham
Comment 2 2020-01-15 17:27:38 PST
Comment on attachment 387872 [details] Patch Looks good. r=me.
Don Olmstead
Comment 3 2020-01-15 17:33:18 PST
Looks good to me as well just wondering if we want to have the target files in a target directory.
Per Arne Vollan
Comment 4 2020-01-15 19:47:03 PST
Created attachment 387889 [details] Patch
Per Arne Vollan
Comment 5 2020-01-15 19:47:42 PST
(In reply to Brent Fulgham from comment #2) > Comment on attachment 387872 [details] > Patch > > Looks good. r=me. Thanks for reviewing!
Per Arne Vollan
Comment 6 2020-01-15 19:48:01 PST
(In reply to Don Olmstead from comment #3) > Looks good to me as well just wondering if we want to have the target files > in a target directory. Fixed. Thanks for reviewing!
Per Arne Vollan
Comment 7 2020-01-15 19:49:02 PST
rdar://problem/58379794
WebKit Commit Bot
Comment 8 2020-01-16 07:57:01 PST
Comment on attachment 387889 [details] Patch Clearing flags on attachment: 387889 Committed r254681: <https://trac.webkit.org/changeset/254681>
WebKit Commit Bot
Comment 9 2020-01-16 07:57:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.