Bug 206251

Summary: AX: Implement support for ARIA 1.3 roles mark, suggestion (ARIA Annotations)
Product: WebKit Reporter: Aaron Leventhal <aleventhal>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, jhoffman23, marco.zehe, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 12   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Aaron Leventhal 2020-01-14 12:35:09 PST 
ARIA 1.3 has added these roles to support ARIA annotations.

In addition, mark provides role parity with <mark>.
Comment 1 Radar WebKit Bug Importer 2020-01-14 12:35:24 PST 
<rdar://problem/58577388>
Comment 2 James Craig 2020-03-04 16:43:17 PST 
Aaron requested public comment. I can confirm that Apple Accessibility Engineering has no concern with the ARIA Annotations proposal and intends to implement the mark role. I can't promise a specific date though.
Comment 3 Joshua Hoffman 2022-08-26 16:35:21 PDT 
Created attachment 461902 [details]
Patch
Comment 4 chris fleizach 2022-08-26 17:05:34 PDT 
Comment on attachment 461902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461902&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2835
> +    return Accessibility::findAncestor(*self.axBackingObject, false, [] (const auto& object) {

ancestorWithRole

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:2031
> +        { "isMark", getIsMarkAnnotationCallback, 0 , kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },

maybe call isMarkAnnotation since that what the rest of the methods call it
Comment 5 Joshua Hoffman 2022-08-26 17:18:29 PDT 
Created attachment 461906 [details]
Patch
Comment 6 Joshua Hoffman 2022-08-29 10:14:03 PDT 
Created attachment 461986 [details]
Patch
Comment 7 Joshua Hoffman 2022-08-30 09:07:00 PDT 
Created attachment 462010 [details]
Patch
Comment 8 Joshua Hoffman 2022-08-30 13:58:56 PDT 
Created attachment 462016 [details]
Patch
Comment 9 Andres Gonzalez 2022-08-31 10:12:57 PDT 
(In reply to Joshua Hoffman from comment #8)
> Created attachment 462016 [details]
> Patch

--- a/LayoutTests/accessibility/mac/mark-role.html
+++ a/LayoutTests/accessibility/mac/mark-role.html

Shouldn't we also test the role in addition to the attributed string?
Comment 10 Andres Gonzalez 2022-08-31 10:15:31 PDT 
(In reply to Andres Gonzalez from comment #9)
> (In reply to Joshua Hoffman from comment #8)
> > Created attachment 462016 [details]
> > Patch
> 
> --- a/LayoutTests/accessibility/mac/mark-role.html
> +++ a/LayoutTests/accessibility/mac/mark-role.html
> 
> Shouldn't we also test the role in addition to the attributed string?

Ah I see, you are doing it in roles-computedRoleString.html.
Comment 11 EWS 2022-08-31 13:35:27 PDT 
Committed 254008@main (335a5587c312): <https://commits.webkit.org/254008@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462016 [details].