Bug 20624

Summary: WebKit-gtk uses deprecated GtkType/GtkObject
Product: WebKit Reporter: Chris Lord <chris>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: christian
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch to remove deprecated Gtk types/functions in webkit-gtk
none
Patch to remove deprecated Gtk types/functions in webkit-gtk alp: review+

Chris Lord
Reported 2008-09-03 05:24:50 PDT
The plugin widget in webkit-gtk uses GtkType instead of GType. The means it fails to build with GTK without deprecated functions enabled (and will fail to build when these functions are removed). The attached patch fixes that (and works fine, in my testing).
Attachments
Patch to remove deprecated Gtk types/functions in webkit-gtk (1.71 KB, patch)
2008-09-03 05:25 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch to remove deprecated Gtk types/functions in webkit-gtk (1.78 KB, patch)
2008-09-03 08:22 PDT, Chris Lord 		alp: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2008-09-03 05:25:51 PDT
Created attachment 23138 [details] Patch to remove deprecated Gtk types/functions in webkit-gtk
Chris Lord
Comment 2 2008-09-03 08:22:19 PDT
Created attachment 23142 [details] Patch to remove deprecated Gtk types/functions in webkit-gtk Fixed coding style (hopefully).
Christian Dywan
Comment 3 2008-09-10 03:54:53 PDT
(In reply to comment #2) > Created an attachment (id=23142) [edit] > Patch to remove deprecated Gtk types/functions in webkit-gtk > > Fixed coding style (hopefully). While you are at it, can't we use G_DEFINE_TYPE? Btw you should mark patches with a ? if you want them to be reviewed.
Jan Alonzo
Comment 4 2008-10-05 04:28:32 PDT
Comment on attachment 23142 [details] Patch to remove deprecated Gtk types/functions in webkit-gtk setting patch for review...
Alp Toker
Comment 5 2008-10-05 16:09:44 PDT
Comment on attachment 23142 [details] Patch to remove deprecated Gtk types/functions in webkit-gtk r=me (assuming you checked and it doesn't break Xt plugins) Cheers
Jan Alonzo
Comment 6 2008-10-05 18:43:38 PDT
Thanks guys. Landed in r37322
Note You need to log in before you can comment on or make changes to this bug.