Bug 206173

Summary: [Web Animations] Make Animation.timeline read-write only if a runtime flag is enabled
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, cdumez, dino, esprehn+autocc, ews-watchlist, kondapallykalyan, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 206836    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Antoine Quint
Reported 2020-01-13 06:08:52 PST
There are still some issues to iron out with Animation.timeline being a read-write property, so we should follow what Firefox and Chrome do and make it read-only alone for now.
Attachments
Patch (16.31 KB, patch)
2020-01-27 22:59 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (18.67 KB, patch)
2020-01-28 01:35 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-01-13 06:09:41 PST
Cc'ing Chris Dumez and Sam Weinig for guidance about how to make a property read-only by default and read-write only if a given runtime flag is enabled. I don't think our code generator supports this at the moment.
Radar WebKit Bug Importer
Comment 2 2020-01-13 06:09:57 PST
<rdar://problem/58527432>
Antoine Quint
Comment 3 2020-01-27 22:59:20 PST
Created attachment 388971 [details] Patch
Antoine Quint
Comment 4 2020-01-28 01:35:21 PST
Created attachment 388976 [details] Patch
Antoine Quint
Comment 5 2020-01-28 05:38:32 PST
Committed r255234: <https://trac.webkit.org/changeset/255234>
Note You need to log in before you can comment on or make changes to this bug.