Bug 206172

Summary:

Split AudioTrackPrivateMediaStreamCocoa to implement remote audio rendering

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, peng.liu6, philipj, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

youenn fablet

Reported 2020-01-13 05:14:55 PST

Split AudioTrackPrivateMediaStreamCocoa to implement remote audio rendering

Attachments
Patch (62.54 KB, patch) 2020-01-13 05:24 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (62.18 KB, patch) 2020-01-13 05:44 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (63.90 KB, patch) 2020-01-13 05:59 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (63.95 KB, patch) 2020-01-13 06:28 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (63.76 KB, patch) 2020-01-13 06:57 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (63.78 KB, patch) 2020-01-13 07:43 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (64.32 KB, patch) 2020-01-13 08:11 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2020-01-13 05:24:21 PST

Created attachment 387515 [details] Patch

Radar WebKit Bug Importer

Comment 2 2020-01-13 05:27:41 PST

<rdar://problem/58526733>

youenn fablet

Comment 3 2020-01-13 05:44:40 PST

Created attachment 387516 [details] Patch

Eric Carlson

Comment 4 2020-01-13 05:52:54 PST

Comment on attachment 387515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387515&action=review > Source/WebCore/ChangeLog:9 > + For that purpose, splut AudioTrackPrivateMediaStreamCocoa functionality in two parts. s/splut/split/ > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:111 > +// May get called on a background thread. Should we protect access to the renderer with a lock so, e.g., problems when clear() and audioSamplesAvailable() are called concurrently? > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h:77 > + AtomString language() const final { return emptyAtom(); } This override isn't necessary as the base class already returns emptyAtom();

youenn fablet

Comment 5 2020-01-13 05:56:18 PST

(In reply to Eric Carlson from comment #4) > Comment on attachment 387515 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387515&action=review > > > Source/WebCore/ChangeLog:9 > > + For that purpose, splut AudioTrackPrivateMediaStreamCocoa functionality in two parts. > > s/splut/split/ OK > > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:111 > > +// May get called on a background thread. > > Should we protect access to the renderer with a lock so, e.g., problems when > clear() and audioSamplesAvailable() are called concurrently? We should be good now and the old code making a protectedThis is a left over. Reason is that we should call clear() before entering the destructor. > > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h:77 > > + AtomString language() const final { return emptyAtom(); } > > This override isn't necessary as the base class already returns emptyAtom(); OK

youenn fablet

Comment 6 2020-01-13 05:59:04 PST

Created attachment 387519 [details] Patch

youenn fablet

Comment 7 2020-01-13 06:28:17 PST

Created attachment 387521 [details] Patch

youenn fablet

Comment 8 2020-01-13 06:57:05 PST

Created attachment 387524 [details] Patch

youenn fablet

Comment 9 2020-01-13 07:43:10 PST

Created attachment 387526 [details] Patch