Summary: | Split AudioTrackPrivateMediaStreamCocoa to implement remote audio rendering | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, peng.liu6, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
youenn fablet
2020-01-13 05:14:55 PST
Created attachment 387515 [details]
Patch
Created attachment 387516 [details]
Patch
Comment on attachment 387515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387515&action=review > Source/WebCore/ChangeLog:9 > + For that purpose, splut AudioTrackPrivateMediaStreamCocoa functionality in two parts. s/splut/split/ > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:111 > +// May get called on a background thread. Should we protect access to the renderer with a lock so, e.g., problems when clear() and audioSamplesAvailable() are called concurrently? > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h:77 > + AtomString language() const final { return emptyAtom(); } This override isn't necessary as the base class already returns emptyAtom(); (In reply to Eric Carlson from comment #4) > Comment on attachment 387515 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387515&action=review > > > Source/WebCore/ChangeLog:9 > > + For that purpose, splut AudioTrackPrivateMediaStreamCocoa functionality in two parts. > > s/splut/split/ OK > > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:111 > > +// May get called on a background thread. > > Should we protect access to the renderer with a lock so, e.g., problems when > clear() and audioSamplesAvailable() are called concurrently? We should be good now and the old code making a protectedThis is a left over. Reason is that we should call clear() before entering the destructor. > > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h:77 > > + AtomString language() const final { return emptyAtom(); } > > This override isn't necessary as the base class already returns emptyAtom(); OK Created attachment 387519 [details]
Patch
Created attachment 387521 [details]
Patch
Created attachment 387524 [details]
Patch
Created attachment 387526 [details]
Patch
Created attachment 387529 [details]
Patch
Comment on attachment 387529 [details] Patch Clearing flags on attachment: 387529 Committed r254446: <https://trac.webkit.org/changeset/254446> All reviewed patches have been landed. Closing bug. |