Bug 206165

Summary: [LFC][Integration] Build and enable on Windows
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, commit-queue, darin, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch none

Description Antti Koivisto 2020-01-13 02:28:19 PST
LFC is not currently building on windows.
Comment 1 Don Olmstead 2020-01-15 11:17:26 PST
Antti our IRC connection is down otherwise I'd ping you directly. LineBreaker::Run::operator= is missing.
Comment 2 Antti Koivisto 2020-01-15 11:22:13 PST
I guess VC++ has trouble with vectors and move semantics?
Comment 3 Don Olmstead 2020-01-23 10:39:23 PST
Created attachment 388561 [details]
Patch
Comment 4 Don Olmstead 2020-01-23 11:52:47 PST
On IRC anttik mentioned that LFC had been turned off due to perf issues. This patch just enables LFC on WinCairo when experimental features are enabled. So the feature will be ON for developers only. It will also catch any build errors when using MSVC around the feature.

We personally think its fine to land this assuming a r+.
Comment 5 Antti Koivisto 2020-01-27 01:09:01 PST
We are back to enabled on Mac so this is ok.
Comment 6 Don Olmstead 2020-01-28 11:58:24 PST
Created attachment 389046 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-28 13:01:30 PST
The commit-queue encountered the following flaky tests while processing attachment 389046 [details]:

http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-28 13:01:53 PST
The commit-queue encountered the following flaky tests while processing attachment 389046 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-01-28 13:20:31 PST
Comment on attachment 389046 [details]
Patch

Clearing flags on attachment: 389046

Committed r255273: <https://trac.webkit.org/changeset/255273>
Comment 10 WebKit Commit Bot 2020-01-28 13:20:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2020-01-28 13:21:15 PST
<rdar://problem/58966926>