Summary: | [LFC][Integration] Build and enable on Windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Layout and Rendering | Assignee: | Don Olmstead <don.olmstead> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, bfulgham, commit-queue, darin, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2020-01-13 02:28:19 PST
Antti our IRC connection is down otherwise I'd ping you directly. LineBreaker::Run::operator= is missing. I guess VC++ has trouble with vectors and move semantics? Created attachment 388561 [details]
Patch
On IRC anttik mentioned that LFC had been turned off due to perf issues. This patch just enables LFC on WinCairo when experimental features are enabled. So the feature will be ON for developers only. It will also catch any build errors when using MSVC around the feature. We personally think its fine to land this assuming a r+. We are back to enabled on Mac so this is ok. Created attachment 389046 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 389046 [details]: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 389046 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 389046 [details] Patch Clearing flags on attachment: 389046 Committed r255273: <https://trac.webkit.org/changeset/255273> All reviewed patches have been landed. Closing bug. |