Bug 206159

Summary: [EWS] Add unit tests for factories
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jbedard: review+

Aakash Jain
Reported 2020-01-12 17:26:25 PST
Add unit tests for EWS factories.
Attachments
Patch (9.10 KB, patch)
2020-01-12 17:35 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (9.11 KB, patch)
2020-01-13 13:11 PST, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-01-12 17:35:02 PST
Created attachment 387498 [details] Patch
Alexey Proskuryakov
Comment 2 2020-01-12 17:44:12 PST
Comment on attachment 387498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387498&action=review > Tools/ChangeLog:3 > + [EWS] Add unit tests for factories Will this run as part of an existing test suite on bots?
Aakash Jain
Comment 3 2020-01-12 17:53:11 PST
(In reply to Alexey Proskuryakov from comment #2) > Will this run as part of an existing test suite on bots? Yes, in fact these unit-tests were automatically run by the Services EWS for this patch as well (since runUnittests.py script automatically runs _unittest.py files in that directory). The corresponding build for this patch run 180 tests (in https://ews-build.webkit.org/#/builders/20/builds/11417/steps/7/logs/stdio), while previously 172 tests were being run (e.g.: https://ews-build.webkit.org/#/builders/20/builds/11092/steps/7/logs/stdio).
Jonathan Bedard
Comment 4 2020-01-13 09:28:47 PST
Comment on attachment 387498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387498&action=review >> Tools/ChangeLog:3 >> + [EWS] Add unit tests for factories > > Will this run as part of an existing test suite on bots? Yes, Tools/BuildSlaveSupport/ews-build/runUnittests.py will pick it up. > Tools/BuildSlaveSupport/ews-build/factories_unittest.py:40 > + actual_steps = map(step_to_dict, actual_steps) I would expect the style checker to want an empty line here to separate the function
Aakash Jain
Comment 5 2020-01-13 13:11:48 PST
Created attachment 387561 [details] Patch
Aakash Jain
Comment 6 2020-01-13 13:14:42 PST
(In reply to Jonathan Bedard from comment #4) > I would expect the style checker to want an empty line here to separate the function Added empty line.
Aakash Jain
Comment 7 2020-01-13 13:33:06 PST
Committed r254448: <https://trac.webkit.org/changeset/254448>
Radar WebKit Bug Importer
Comment 8 2020-01-13 13:34:11 PST
<rdar://problem/58541484>
Note You need to log in before you can comment on or make changes to this bug.