| Summary: | [WebCore] Reorganize JSType in WebCore to offer more bits to JSC | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-01-12 01:55:35 PST
Created attachment 387464 [details]
Patch
Comment on attachment 387464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review r=me. We have 128 types these days?!? O.o > Source/WebCore/bindings/js/JSDOMWrapper.h:32 > // JSC allows us to extend JSType. If the highest bit is set, we can add any Object types and they are Can you fix this comment to match the new rule. Comment on attachment 387464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review >> Source/WebCore/bindings/js/JSDOMWrapper.h:32 >> // JSC allows us to extend JSType. If the highest bit is set, we can add any Object types and they are > > Can you fix this comment to match the new rule. Fixed. Committed r254416: <https://trac.webkit.org/changeset/254416> Comment on attachment 387464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review > Source/JavaScriptCore/runtime/JSType.h:140 > +static_assert(LastJSCObjectType < 0b11100000, "Embedder can use 0b11100000 or upper."); I think you meant to say "above" instead of "upper". |