Summary: | [JSC] Remove IsDone from JSArrayIterator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-01-12 01:10:35 PST
Created attachment 387461 [details]
Patch
Comment on attachment 387461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387461&action=review > Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:-549 > - clone->internalField(JSArrayIterator::Field::IsDone).set(vm, clone, iteratorObject->internalField(JSArrayIterator::Field::IsDone).get()); I think we should still show this in Web Inspector, as it’s useful for developers to know when debugging. Comment on attachment 387461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387461&action=review The test failures look unrelated. >> Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:-549 >> - clone->internalField(JSArrayIterator::Field::IsDone).set(vm, clone, iteratorObject->internalField(JSArrayIterator::Field::IsDone).get()); > > I think we should still show this in Web Inspector, as it’s useful for developers to know when debugging. You can show in the inspector side by comparing `index === -1`. Currently, inspector is not showing it. Created attachment 387492 [details]
Patch
Comment on attachment 387492 [details]
Patch
Have you run the microbenchmarks to see if there's a significant difference?
(In reply to Keith Miller from comment #5) > Comment on attachment 387492 [details] > Patch > > Have you run the microbenchmarks to see if there's a significant difference? No difference. This change is basically for JSStringIterator to use the same mechanism to keep sizeof(JSStringIterator) small. Cool LGTM then Committed r254419: <https://trac.webkit.org/changeset/254419> |