Bug 206124

Summary: Platform.h is out of control Part 1: Split WTF_CPU_* macro definitions out of Platform.h and into a new CPU.h
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, annulen, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2020-01-10 21:34:11 PST
Split WTF_CPU_* macro definitions out of Platform.h and into a new CPU.h
Attachments
Patch (106.44 KB, patch)
2020-01-10 21:36 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-01-10 21:36:58 PST
Created attachment 387421 [details] Patch
Anders Carlsson
Comment 2 2020-01-11 07:41:07 PST
Comment on attachment 387421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387421&action=review > Source/WTF/wtf/CPU.h:186 > +// FIXME: WTF_THUMB_ARCH_VERSION seems unusued. Remove. *unusued*. > Source/WTF/wtf/Platform.h:81 > +/* FIXME: This should be renamed to WTF_CPU_ARM_IDIV_INSTRUCTIONS and moved to CPU.h */ Why use C comments here?
Sam Weinig
Comment 3 2020-01-11 10:07:06 PST
Committed r254401: <https://trac.webkit.org/changeset/254401>
Sam Weinig
Comment 4 2020-01-11 10:08:01 PST
(In reply to Anders Carlsson from comment #2) > Comment on attachment 387421 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387421&action=review > > > Source/WTF/wtf/CPU.h:186 > > +// FIXME: WTF_THUMB_ARCH_VERSION seems unusued. Remove. > > *unusued*. Fixed. > > > Source/WTF/wtf/Platform.h:81 > > +/* FIXME: This should be renamed to WTF_CPU_ARM_IDIV_INSTRUCTIONS and moved to CPU.h */ > > Why use C comments here? The whole file is supposed to uses C comments so it can be included in C files. I fixed the other one to also be a C comment. Thanks for the review.
Radar WebKit Bug Importer
Comment 5 2020-01-11 10:08:11 PST
<rdar://problem/58504848>
Note You need to log in before you can comment on or make changes to this bug.