Bug 206104

Summary: Expose frame information on _WKResourceLoadInfo
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch dino: review+

Alex Christensen
Reported 2020-01-10 15:38:13 PST
Expose frame information on _WKResourceLoadInfo
Attachments
Patch (24.35 KB, patch)
2020-01-10 15:43 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (24.55 KB, patch)
2020-01-10 16:14 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (24.55 KB, patch)
2020-01-10 16:57 PST, Alex Christensen 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-01-10 15:43:17 PST
Created attachment 387387 [details] Patch
Alex Christensen
Comment 2 2020-01-10 16:14:15 PST
Created attachment 387390 [details] Patch
Alex Christensen
Comment 3 2020-01-10 16:57:50 PST
Created attachment 387398 [details] Patch
Dean Jackson
Comment 4 2020-01-11 12:37:08 PST
Comment on attachment 387398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387398&action=review > Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.mm:93 > + [coder encodeObject:@([self frameID]) forKey:@"frameID"]; self.frameID ? > Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:596 > - if (page) > - loadParameters.pageHasResourceLoadClient = page->hasResourceLoadClient(); > + addParametersFromFrame(webFrame->coreFrame(), loadParameters); I assume it is totally ok that the loadParameters here might get .isHTTPSUpgradeEnabled set now, when it didn't before? > Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:662 > + addParametersFromFrame(&frame, loadParameters); Same here.
Alex Christensen
Comment 5 2020-01-11 17:42:06 PST
(In reply to Dean Jackson from comment #4) > I assume it is totally ok that the loadParameters here might get > .isHTTPSUpgradeEnabled set now, when it didn't before? Yes, that was an oversight before. We want https upgrade for sync xhr and beacon.
Alex Christensen
Comment 6 2020-01-11 17:47:04 PST
http://trac.webkit.org/r254409
Radar WebKit Bug Importer
Comment 7 2020-01-11 17:48:13 PST
<rdar://problem/58507584>
Note You need to log in before you can comment on or make changes to this bug.