| Summary: | Expose frame information on _WKResourceLoadInfo | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2020-01-10 15:38:13 PST
Created attachment 387387 [details]
Patch
Created attachment 387390 [details]
Patch
Created attachment 387398 [details]
Patch
Comment on attachment 387398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387398&action=review > Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.mm:93 > + [coder encodeObject:@([self frameID]) forKey:@"frameID"]; self.frameID ? > Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:596 > - if (page) > - loadParameters.pageHasResourceLoadClient = page->hasResourceLoadClient(); > + addParametersFromFrame(webFrame->coreFrame(), loadParameters); I assume it is totally ok that the loadParameters here might get .isHTTPSUpgradeEnabled set now, when it didn't before? > Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:662 > + addParametersFromFrame(&frame, loadParameters); Same here. (In reply to Dean Jackson from comment #4) > I assume it is totally ok that the loadParameters here might get > .isHTTPSUpgradeEnabled set now, when it didn't before? Yes, that was an oversight before. We want https upgrade for sync xhr and beacon. |