| Summary: | AnimationController.cpp should be split into separate files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Marrin <cmarrin> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
Created attachment 23122 [details]
Patch to fix bug
Comment on attachment 23122 [details]
Patch to fix bug
The Windows project file changes aren't right. Each file needs to get its own individual <File> entry. Look more closely at the file and you'll see what I mean.
Created attachment 23129 [details]
Second attempt at patch to fix issues in WebCore.vcproj
Comment on attachment 23129 [details]
Second attempt at patch to fix issues in WebCore.vcproj
r=me
Committed r36031 M WebCore/GNUmakefile.am M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/WebCore.pro M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCoreSources.bkl D WebCore/page/AnimationController.h D WebCore/page/AnimationController.cpp A WebCore/page/animation/AnimationBase.h A WebCore/page/animation/ImplicitAnimation.h A WebCore/page/animation/CompositeAnimation.cpp A WebCore/page/animation/AnimationController.cpp A WebCore/page/animation/KeyframeAnimation.cpp A WebCore/page/animation/CompositeAnimation.h A WebCore/page/animation/AnimationController.h A WebCore/page/animation/KeyframeAnimation.h A WebCore/page/animation/AnimationBase.cpp A WebCore/page/animation/ImplicitAnimation.cpp |
The file has gotten very large and unweildy. I propose we split it into 5 parts: AnimationController CompositeAnimation AnimationBase ImplicitAnimation KeyframeAnimation and put them all into a new subdirectory of page named 'animation'