Summary: | [LFC] Rename UsedHorizontal(Vertical)Values to OverrideHorizontal(Vertical)values | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2020-01-09 07:49:27 PST
Created attachment 387231 [details]
Patch
Comment on attachment 387231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387231&action=review > Source/WebCore/ChangeLog:16 > + values for the "compute geometry" functions (e.g. computing the width of a floating box follows > + the same set of steps as computing the width of an inline replaced box. So whenever we need to > + compute the width of a floating box, we could just call the computeInlineReplacedWidth() function. > + However their horizontal margin computations are different and since width and horizontal margins are being computed together, > + we need to make sure that inlineReplacedWidthAndMargin() takes a set of pre-computed margin values > + and uses them while computing the width value. Same applies to min/max-width/heigh computations.) One day you'll put the entire ChangeLog entry inside parentheses. (In reply to Antti Koivisto from comment #3) > Comment on attachment 387231 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387231&action=review > > > Source/WebCore/ChangeLog:16 > > + values for the "compute geometry" functions (e.g. computing the width of a floating box follows > > + the same set of steps as computing the width of an inline replaced box. So whenever we need to > > + compute the width of a floating box, we could just call the computeInlineReplacedWidth() function. > > + However their horizontal margin computations are different and since width and horizontal margins are being computed together, > > + we need to make sure that inlineReplacedWidthAndMargin() takes a set of pre-computed margin values > > + and uses them while computing the width value. Same applies to min/max-width/heigh computations.) > > One day you'll put the entire ChangeLog entry inside parentheses. That's one of my 2020 resolutions. Committed r254277: <https://trac.webkit.org/changeset/254277> |