Summary: | REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Iván Garcia <desconocios> | ||||||||||
Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, bdakin, cdumez, commit-queue, desconocios, eflews.bot, eric.carlson, grahamperrin, gyuyoung.kim, gyuyoung.kim, philn, rakuco, rego+ews, ruthiecftg, thorton, webkit-ews, xan.lopez | ||||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
URL: | http://youtube.seeqpod.com/m/La%20Oreja%20De%20Van%20Gogh%20-%20La%20Playa.mp3?t=1e3de8f893b76b3d1f79e57dea8917d0ece4325fe3d313f5d2ed495f533bf012f882575cac07c41c&h=7084f17d661556684c7cc8c7e015bb55feba8cfa | ||||||||||||
Attachments: |
|
Description
Iván Garcia
2008-09-02 04:33:59 PDT
Giving this the full regression treatment (I haven't attempted to reproduce this though). The available controls are different because you're comparing the <video> element (which is used when you load a media file directly, via the MediaDocument), with the QuickTime plug-in. The <video> element controls do not have affordance for saving the movie. This is by design. Created attachment 204740 [details]
Patch
Comment on attachment 204740 [details] Patch Attachment 204740 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/923058 Comment on attachment 204740 [details] Patch Attachment 204740 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/890138 Comment on attachment 204740 [details] Patch Attachment 204740 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/921059 Comment on attachment 204740 [details] Patch Attachment 204740 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/920060 Created attachment 204745 [details]
Patch
Created attachment 204746 [details]
Patch
Comment on attachment 204746 [details] Patch Attachment 204746 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/906106 Comment on attachment 204746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204746&action=review > Source/WebCore/page/ContextMenuController.cpp:258 > + // FIXME: Some day we should be able to do this from within WebCore. Please file a bug and reference it in the FIXME. Created attachment 204843 [details]
Patch
(In reply to comment #13) > (From update of attachment 204746 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204746&action=review > > > Source/WebCore/page/ContextMenuController.cpp:258 > > + // FIXME: Some day we should be able to do this from within WebCore. > > Please file a bug and reference it in the FIXME. Bug 117709 now tracks this issue. Comment on attachment 204843 [details] Patch Clearing flags on attachment: 204843 Committed r151656: <http://trac.webkit.org/changeset/151656> All reviewed patches have been landed. Closing bug. |