Bug 205980

Summary: Set the title for images so it will be correctly displayed in UIContextMenus
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Megan Gardner
Reported 2020-01-08 18:15:41 PST
Set the title for images so it will be correctly displayed in UIContextMenus
Attachments
Patch (1.80 KB, patch)
2020-01-08 18:16 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.82 KB, patch)
2020-01-09 11:30 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-01-08 18:16:51 PST
Created attachment 387175 [details] Patch
Megan Gardner
Comment 2 2020-01-08 18:17:46 PST
<rdar://problem/57701988>
Tim Horton
Comment 3 2020-01-08 23:02:59 PST
Comment on attachment 387175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387175&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8483 > + return [UIMenu menuWithTitle:[elementInfo title] children:actions]; I still maintain you should use positionInfo here, not the API wrapper :)
Megan Gardner
Comment 4 2020-01-09 11:30:44 PST
Created attachment 387248 [details] Patch for landing
WebKit Commit Bot
Comment 5 2020-01-09 13:10:24 PST
Comment on attachment 387248 [details] Patch for landing Clearing flags on attachment: 387248 Committed r254292: <https://trac.webkit.org/changeset/254292>
WebKit Commit Bot
Comment 6 2020-01-09 13:10:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.