Bug 205927
| Summary: | few web-platform-tests are failing on iOS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Pablo Saavedra <psaavedra> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, psaavedra, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=205639 | ||
Aakash Jain
Following web-platform-tests are failing consistently on iOS:
imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https.html
imported/w3c/web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta.html
imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html
imported/w3c/web-platform-tests/xhr/event-timeout-order.any.html
Seems like it was caused by https://trac.webkit.org/changeset/254133/webkit
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Haddad
The diffs for the CSP tests suggest that they may just need iOS baselines:
--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https-actual.txt
@@ -1,5 +1,4 @@
-Harness Error (FAIL), message = TypeError: undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
-NOTRUN A 'frame-ancestors' CSP directive set from a serviceworker response with a value 'none' should block rendering.
+PASS A 'frame-ancestors' CSP directive set from a serviceworker response with a value 'none' should block rendering.
--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta-actual.txt
@@ -1,4 +1,4 @@
-Blocked access to external URL http://www1.%7B%7Bhost%7D%7D/content-security-policy/support/frame.html#0
+Blocked access to external URL http://www1.{{host}}/content-security-policy/support/frame.html#0
Harness Error (TIMEOUT), message = null
--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub-actual.txt
@@ -1,4 +1,6 @@
PASS Image should load
+PASS checkReport tests loaded
+PASS Violation report status OK.
Ryan Haddad
The XHR one came from https://trac.webkit.org/changeset/254154/webkit
Also looks like it needs an iOS baseline:
--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout-order.any-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout-order.any-actual.txt
@@ -1,3 +1,3 @@
-FAIL XMLHttpRequest: event - timeout (order of events) assert_equals: expected "readystatechange(4)" but got "upload.progress(12,12,true)"
+PASS XMLHttpRequest: event - timeout (order of events)
Ryan Haddad
Added iOS baselines in http://trac.webkit.org/r254231
Radar WebKit Bug Importer
<rdar://problem/58424725>
Pablo Saavedra
Thanks Ryan Haddad to take care about the missing baselines for ios-wk2.