Summary: | Fix specification violation in Font Loading API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Myles C. Maxfield
2020-01-07 19:46:20 PST
Created attachment 387062 [details]
Patch
Comment on attachment 387062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387062&action=review > Source/WebCore/ChangeLog:3 > + Supplying CSS global keywords to the Font Loading API can cause crashes Suggest changing the title to something like: "Fix specification violation in Font Loading API" > Source/WebCore/ChangeLog:9 > + Simply add a check. The spec says: Then say: "Our Font Loading API does not comply with the spec: <<< spec language >>>" "Rather than crashing, we should return a syntax error." > LayoutTests/fast/text/font-loading-global-keyword-expected.txt:1 > +This test passes if there is no crash. I don't think this is true. The test passes if we get the expected syntax errors. No need to say something about a crash (all of our tests are expected to pass without crashing!) > LayoutTests/fast/text/font-loading-global-keyword.html:8 > +description("This test passes if there is no crash."); description("This test ensure that global CSS keywords generate expected syntax errors."); Created attachment 387128 [details]
Patch for committing
Comment on attachment 387128 [details] Patch for committing Clearing flags on attachment: 387128 Committed r254220: <https://trac.webkit.org/changeset/254220> |