| Summary: | Reformat WebProcessPool logging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||
| Component: | WebKit Misc. | Assignee: | Keith Rollin <krollin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=205679 | ||||||
| Attachments: |
|
||||||
Created attachment 387021 [details]
Patch
Comment on attachment 387021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387021&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:110 > +#define WEBPROCESSPOOL_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - WebProcessPool::" fmt, this, ##__VA_ARGS__) Should we #undef this at the end of the file? > Source/WebKit/UIProcess/WebProcessPool.cpp:141 > +#define WEBPROCESSPOOL_RELEASE_LOG_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_IF(sessionID.isAlwaysOnLoggingAllowed(), channel, "%p - WebProcessPool::" fmt, this, ##__VA_ARGS__) Should you be #undef these at the end, in case these get concatenated into UnifiedBuild? (In reply to Brent Fulgham from comment #3) > Comment on attachment 387021 [details] > Should you be #undef these at the end, in case these get concatenated into > UnifiedBuild? Good question. We #undef in the case where the macros we define are generic, such as RELEASE_LOG_IF_ALLOWED. However, I prefixed these with "WEBPROCESSPOOL_", creating a bit of a namespace that should prevent any collision with other unified files. I'm thinking of going forward with this approach on future files I modify, and going back to other files I've recently modified and ensuring they also take the same approach. Comment on attachment 387021 [details]
Patch
r=me
Comment on attachment 387021 [details] Patch Clearing flags on attachment: 387021 Committed r254487: <https://trac.webkit.org/changeset/254487> All reviewed patches have been landed. Closing bug. |
Update the format used by WebProcessPool in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: Using prewarmed process 0 becomes: 0x7f81e8804008 - WebProcessPool::processForRegistrableDomain: Using prewarmed process (process=0x1471c2a00, PID=64197)