Bug 205880

Summary: [JSC] Remove vm accessor in JSVirtualMachine to reduce binary size
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205877    
Bug Blocks:    
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-01-07 12:14:43 PST
...
Attachments
Patch (5.46 KB, patch)
2020-01-07 12:30 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-01-07 12:22:59 PST
Let's do it right now since it is the largest.
Yusuke Suzuki
Comment 2 2020-01-07 12:30:58 PST
Created attachment 387019 [details] Patch
Yusuke Suzuki
Comment 3 2020-01-07 12:32:30 PST
Comment on attachment 387019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387019&action=review > Source/JavaScriptCore/API/JSVirtualMachine.mm:301 > +- (JSContextGroupRef)JSContextGroupRef This style is following `JSContext JSContextRef` accessor.
Mark Lam
Comment 4 2020-01-07 12:35:28 PST
Comment on attachment 387019 [details] Patch Nice. r=me if bots are green. Please also run testapi locally to make sure there are no bad surprises (not expecting any).
Yusuke Suzuki
Comment 5 2020-01-07 13:10:47 PST
(In reply to Mark Lam from comment #4) > Comment on attachment 387019 [details] > Patch > > Nice. r=me if bots are green. Please also run testapi locally to make sure > there are no bad surprises (not expecting any). OK, ensured locally.
Yusuke Suzuki
Comment 6 2020-01-07 13:13:29 PST
Committed r254152: <https://trac.webkit.org/changeset/254152>
Radar WebKit Bug Importer
Comment 7 2020-01-07 13:14:19 PST
<rdar://problem/58385111>
Note You need to log in before you can comment on or make changes to this bug.