Bug 205871

Summary: Bytecode checkpoint fixes for arm64(e)
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch msaboff: review+

Keith Miller
Reported 2020-01-07 10:53:00 PST
Bytecode checkpoint fixes for arm64(e)
Attachments
Patch (4.01 KB, patch)
2020-01-07 10:57 PST, Keith Miller 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-01-07 10:57:34 PST
Created attachment 386998 [details] Patch
Michael Saboff
Comment 2 2020-01-07 11:01:16 PST
Comment on attachment 386998 [details] Patch r=me
Keith Miller
Comment 3 2020-01-07 11:02:15 PST
rdar://problem/58310178
Saam Barati
Comment 4 2020-01-07 11:03:06 PST
Comment on attachment 386998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386998&action=review > Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:150 > + return LLInt::getCodePtr<NoPtrTag>(checkpoint_osr_exit_from_inlined_call_trampoline).executableAddress(); why not make this function return a typed value instead of void*, and then caller's can unbox as needed?
Saam Barati
Comment 5 2020-01-07 11:03:18 PST
r=me too
Keith Miller
Comment 6 2020-01-07 11:42:04 PST
Comment on attachment 386998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386998&action=review >> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:150 >> + return LLInt::getCodePtr<NoPtrTag>(checkpoint_osr_exit_from_inlined_call_trampoline).executableAddress(); > > why not make this function return a typed value instead of void*, and then caller's can unbox as needed? Done, I went with MacroAssemblerCodePtr<JSEntryPtrTag> as the type.
Keith Miller
Comment 7 2020-01-07 11:44:06 PST
Committed r254142: <https://trac.webkit.org/changeset/254142>
Keith Miller
Comment 8 2020-01-07 11:59:30 PST
Non-arm64e build fix in: https://trac.webkit.org/changeset/254143.
Note You need to log in before you can comment on or make changes to this bug.