Bug 205849

Summary: Improve logging of creating a service worker
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2020-01-07 01:16:16 PST
Improve logging of creating a service worker
Attachments
Patch (1.97 KB, patch)
2020-01-07 01:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.55 KB, patch)
2020-01-08 01:42 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-01-07 01:17:41 PST
Created attachment 386949 [details] Patch
Chris Dumez
Comment 2 2020-01-07 07:53:24 PST
Comment on attachment 386949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386949&action=review > Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:158 > + RELEASE_LOG(ServiceWorker, "Created service worker %s in process PID %i", data.serviceWorkerIdentifier.loggingString().utf8().data(), getCurrentProcessID()); %s -> %{public}s Note that personally I prefer using data.serviceWorkerIdentifier.toUInt64() rather than constructing a string. I would actually recommend that instead.
youenn fablet
Comment 3 2020-01-08 01:42:06 PST
Created attachment 387086 [details] Patch for landing
WebKit Commit Bot
Comment 4 2020-01-08 02:29:48 PST
Comment on attachment 387086 [details] Patch for landing Clearing flags on attachment: 387086 Committed r254191: <https://trac.webkit.org/changeset/254191>
WebKit Commit Bot
Comment 5 2020-01-08 02:29:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-01-08 02:30:14 PST
<rdar://problem/58403666>
Note You need to log in before you can comment on or make changes to this bug.