Bug 205838

Summary: Rename start/endPosition to start/endOffset in SelectionRangeData for clarity
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, rniwa, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch
wenson_hsieh: review+
Patch none

Megan Gardner
Reported 2020-01-06 15:38:56 PST
Rename start/endPosition to start/endOffset in SelectionRangeData for clarity
Attachments
Patch (15.16 KB, patch)
2020-01-06 15:46 PST, Megan Gardner 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (16.20 KB, patch)
2020-01-06 17:41 PST, Megan Gardner 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch (17.34 KB, patch)
2020-01-07 11:23 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-01-06 15:46:12 PST
Created attachment 386903 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-01-06 15:47:07 PST
Comment on attachment 386903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386903&action=review > Source/WebCore/ChangeLog:8 > + Offset is a more correct term for this variable, as it it just an unsigned. it it
Megan Gardner
Comment 3 2020-01-06 17:41:32 PST
Created attachment 386920 [details] Patch
Wenson Hsieh
Comment 4 2020-01-06 19:39:44 PST
Comment on attachment 386920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386920&action=review > Source/WebCore/rendering/InlineTextBox.cpp:187 > + auto startPos = selection.startOffset(); > + auto endPos = selection.endOffset(); Let's rename these as well.
Megan Gardner
Comment 5 2020-01-07 11:23:03 PST
Created attachment 387003 [details] Patch
Radar WebKit Bug Importer
Comment 6 2020-01-07 13:56:47 PST
<rdar://problem/58386840>
WebKit Commit Bot
Comment 7 2020-01-07 14:33:42 PST
Comment on attachment 387003 [details] Patch Clearing flags on attachment: 387003 Committed r254159: <https://trac.webkit.org/changeset/254159>
Note You need to log in before you can comment on or make changes to this bug.