Bug 205838

Summary: Rename start/endPosition to start/endOffset in SelectionRangeData for clarity
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, rniwa, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch
wenson_hsieh: review+
Patch none

Description Megan Gardner 2020-01-06 15:38:56 PST 
Rename start/endPosition to start/endOffset in SelectionRangeData for clarity
Comment 1 Megan Gardner 2020-01-06 15:46:12 PST 
Created attachment 386903 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-01-06 15:47:07 PST 
Comment on attachment 386903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386903&action=review

> Source/WebCore/ChangeLog:8
> +        Offset is a more correct term for this variable, as it it just an unsigned.

it it
Comment 3 Megan Gardner 2020-01-06 17:41:32 PST 
Created attachment 386920 [details]
Patch
Comment 4 Wenson Hsieh 2020-01-06 19:39:44 PST 
Comment on attachment 386920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386920&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:187
> +        auto startPos = selection.startOffset();
> +        auto endPos = selection.endOffset();

Let's rename these as well.
Comment 5 Megan Gardner 2020-01-07 11:23:03 PST 
Created attachment 387003 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2020-01-07 13:56:47 PST 
<rdar://problem/58386840>
Comment 7 WebKit Commit Bot 2020-01-07 14:33:42 PST 
Comment on attachment 387003 [details]
Patch

Clearing flags on attachment: 387003

Committed r254159: <https://trac.webkit.org/changeset/254159>