Bug 205835

Summary: [iOS] Get display level in the UI process for all iOS platforms
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch none

Per Arne Vollan
Reported 2020-01-06 14:40:45 PST
This was previously only done for iOS, but should be done for all iOS platforms.
Attachments
Patch (6.20 KB, patch)
2020-01-06 14:50 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (6.25 KB, patch)
2020-01-06 15:32 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (6.24 KB, patch)
2020-01-06 15:41 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-01-06 14:41:08 PST
rdar://problem/58116883
Per Arne Vollan
Comment 2 2020-01-06 14:50:53 PST
Created attachment 386894 [details] Patch
Brent Fulgham
Comment 3 2020-01-06 15:19:35 PST
Comment on attachment 386894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386894&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:551 > +#elif PLATFORM(IOS) I'm not sure this is right. Should this just be "#if PLATFORM(IOS)" and add an #endif? Since the CFNotificationCenterAddObserver is needed by both, but apparently the NSNotification part is only needed for iOS?
Per Arne Vollan
Comment 4 2020-01-06 15:25:59 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 386894 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386894&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:551 > > +#elif PLATFORM(IOS) > > I'm not sure this is right. Should this just be "#if PLATFORM(IOS)" and add > an #endif? Since the CFNotificationCenterAddObserver is needed by both, but > apparently the NSNotification part is only needed for iOS? Ah, you are right. Thanks!
Per Arne Vollan
Comment 5 2020-01-06 15:32:08 PST
Created attachment 386897 [details] Patch
Brent Fulgham
Comment 6 2020-01-06 15:33:07 PST
Comment on attachment 386897 [details] Patch Thank you for fixing that! r=me
Per Arne Vollan
Comment 7 2020-01-06 15:41:19 PST
Created attachment 386902 [details] Patch
Per Arne Vollan
Comment 8 2020-01-06 15:42:02 PST
(In reply to Brent Fulgham from comment #6) > Comment on attachment 386897 [details] > Patch > > Thank you for fixing that! r=me Thanks for reviewing :)
WebKit Commit Bot
Comment 9 2020-01-06 17:06:42 PST
Comment on attachment 386902 [details] Patch Clearing flags on attachment: 386902 Committed r254101: <https://trac.webkit.org/changeset/254101>
Note You need to log in before you can comment on or make changes to this bug.