Bug 205761

Summary:

DumpRenderTree doesn't always call updateRendering() when a test completes

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, darin, rniwa, sabouhallawa, simon.fraser, thorton, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

205694

Attachments:

Description	Flags
Patch	none
Patch	darin: review+

Description Simon Fraser (smfr) 2020-01-03 18:22:11 PST

Fix a souce of WebKit1 test flakiness

Comment 1 Simon Fraser (smfr) 2020-01-03 18:27:28 PST

Created attachment 386740 [details]
Patch

Comment 2 Simon Fraser (smfr) 2020-01-03 18:44:14 PST

Created attachment 386743 [details]
Patch

Comment 3 Darin Adler 2020-01-03 19:30:55 PST

Comment on attachment 386743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386743&action=review

> Source/WebKitLegacy/mac/WebView/WebView.mm:4775
> +    // Ensure fixed positions layers are where they should be.

I think there's a grammar error here. I should be "fixed position layers" maybe?

Comment 4 Simon Fraser (smfr) 2020-01-05 09:58:40 PST

https://trac.webkit.org/changeset/254042/webkit

Comment 5 Radar WebKit Bug Importer 2020-01-05 09:59:23 PST

<rdar://problem/58325946>

Comment 6 Truitt Savell 2020-01-06 10:41:29 PST

The changes in https://trac.webkit.org/changeset/254042/webkit has broken 5 pageoverlay/overlay- tests on Mac wk1

Tracking in https://bugs.webkit.org/show_bug.cgi?id=205810

Comment 7 Ryosuke Niwa 2020-01-13 20:16:18 PST

Nice! Thanks for this fix.