Bug 205743

Summary: [WinCairo] Fixing build after "Add a pure virtual base class for GraphicsContext3D"
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: 1998zhangyi, aakash_jain, cmarcelo, commit-queue, dino, don.olmstead, ews-watchlist, graouts, Hironori.Fujii, kondapallykalyan, luiz, noam, stephan.szabo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Stephan Szabo
Reported 2020-01-03 11:57:17 PST
Some changes were needed after https://trac.webkit.org/changeset/253939/webkit It seems like NO_ERROR was hitting the windows define. Some code being used on wincairo was accessing m_attrs and needed to change. Some functions were showing up as undefined that were in an #ifdef PLATFORM(GTK) && !USE(ANGLE)
Attachments
Patch (3.91 KB, patch)
2020-01-03 12:05 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2020-01-03 12:36 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2020-01-03 12:05:00 PST
Created attachment 386703 [details] Patch Not sure if all the changes here work for other platforms and a bit uncertain about whether the endif move was the right solution.
Stephan Szabo
Comment 2 2020-01-03 12:36:07 PST
Created attachment 386708 [details] Patch Updating to try to fix wpe failure on first patch. Still running build for wincairo locally but want to check wpe's behavior.
Don Olmstead
Comment 3 2020-01-03 14:36:46 PST
Comment on attachment 386708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386708&action=review LGTM. Just making a note that I think we'll want to revisit some of these platform checks since they don't seem correct. > Source/WebCore/platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:483 > +#if (PLATFORM(GTK) && !USE(ANGLE)) || PLATFORM(WIN) I think we maybe need a bug to audit these PLATFORM checks within the GraphicsContext3D stuff. The function glMapBufferRange is just OpenGL(ES) 3+ so this feels wrong.
WebKit Commit Bot
Comment 4 2020-01-03 18:15:58 PST
Comment on attachment 386708 [details] Patch Clearing flags on attachment: 386708 Committed r254026: <https://trac.webkit.org/changeset/254026>
WebKit Commit Bot
Comment 5 2020-01-03 18:16:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-01-03 18:16:15 PST
<rdar://problem/58311654>
Yusuke Suzuki
Comment 7 2020-01-03 19:17:16 PST
Nice!
Fujii Hironori
Comment 8 2020-01-05 21:46:29 PST
*** Bug 205636 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.