Bug 205740

Summary: Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: New BugsAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Description Peng Liu 2020-01-03 11:32:24 PST 
Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process
Comment 1 Radar WebKit Bug Importer 2020-01-03 11:44:50 PST 
<rdar://problem/58303388>
Comment 2 Peng Liu 2020-01-03 11:54:09 PST 
Created attachment 386701 [details]
Patch
Comment 3 Eric Carlson 2020-01-03 12:27:24 PST 
Comment on attachment 386701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386701&action=review

Thanks!

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:94
> +    configuration.engineDescription = m_player->engineDescription();
> +    configuration.supportsScanning = m_player->supportsScanning();
> +    configuration.supportsFullscreen = m_player->supportsFullscreen();
> +    configuration.supportsPictureInPicture = m_player->supportsPictureInPicture();
> +    configuration.supportsAcceleratedRendering = m_player->supportsAcceleratedRendering();
> +    configuration.canPlayToWirelessPlaybackTarget = m_player->canPlayToWirelessPlaybackTarget();

Nit: is there any really you can't use getConfiguration()?
Comment 4 Peng Liu 2020-01-03 12:32:44 PST 
Comment on attachment 386701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386701&action=review

>> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:94
>> +    configuration.canPlayToWirelessPlaybackTarget = m_player->canPlayToWirelessPlaybackTarget();
> 
> Nit: is there any really you can't use getConfiguration()?

No, I should have used getConfiguration() here. Fixed.
Comment 5 Peng Liu 2020-01-03 12:35:17 PST 
Created attachment 386707 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2020-01-03 15:25:44 PST 
Comment on attachment 386707 [details]
Patch for landing

Clearing flags on attachment: 386707

Committed r254019: <https://trac.webkit.org/changeset/254019>