Bug 205692

Summary: Improve release logging in ServiceWorkerFetchTask
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, ggaren, krollin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-01-02 14:01:42 PST 
Improve release logging in ServiceWorkerFetchTask to facilitate debugging.
Comment 1 Chris Dumez 2020-01-02 14:04:25 PST 
Created attachment 386628 [details]
Patch
Comment 2 Keith Rollin 2020-01-02 15:40:16 PST 
Looks good to me.
Comment 3 youenn fablet 2020-01-03 01:04:43 PST 
Comment on attachment 386628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386628&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:252
> +        RELEASE_LOG_IF_ALLOWED("softUpdateIfNeeded: Scheduling soft update");

Would probably be better added in SWServerRegistration::scheduleSoftUpdate given scheduleSoftUpdate is called in two places.
Comment 4 Chris Dumez 2020-01-03 09:04:41 PST 
Created attachment 386688 [details]
Patch
Comment 5 Chris Dumez 2020-01-03 09:24:12 PST 
Comment on attachment 386688 [details]
Patch

Clearing flags on attachment: 386688

Committed r254002: <https://trac.webkit.org/changeset/254002>
Comment 6 Chris Dumez 2020-01-03 09:24:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-03 09:25:25 PST 
<rdar://problem/58299315>