Bug 205687 – [iOS] Replace "unexpectedly resumed" observer with RunningBoard suspendible assertions

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Replace "unexpectedly resumed" observer with RunningBoard suspendible assertions, to avoid unexpected terminations.

[Chris Dumez]

<rdar://problem/57890246>

[Chris Dumez]

Created attachment 386608 [details]
Patch

[Chris Dumez]

Created attachment 386611 [details]
Patch

[Chris Dumez]

Created attachment 386615 [details]
Patch

[Chris Dumez]

Created attachment 386618 [details]
Patch

[Chris Dumez]

Created attachment 386620 [details]
Patch

[Chris Dumez]

Created attachment 386623 [details]
Patch

[Chris Dumez]

Created attachment 386624 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 386624 [details]
Patch

Clearing flags on attachment: 386624

Committed r253984: <https://trac.webkit.org/changeset/253984>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

The changes in https://trac.webkit.org/changeset/253984/webkit

broke testing on iOS Debug

Tracked in https://bugs.webkit.org/show_bug.cgi?id=205727

[Chris Dumez]

Follow-up in <https://trac.webkit.org/changeset/254003>.

[Chris Dumez]

Reopening to revert since this appears to have caused assertion leaks.

[Chris Dumez]

Created attachment 388920 [details]
Patch

[Chris Dumez]

Comment on attachment 388920 [details]
Patch

Clearing flags on attachment: 388920

Committed r255189: <https://trac.webkit.org/changeset/255189>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Reopening since this was reverted but we'll likely try again soon.

[Chris Dumez]

Created attachment 393074 [details]
Patch

[Chris Dumez]

Created attachment 393077 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 393077 [details]
Patch

Clearing flags on attachment: 393077

Committed r258180: <https://trac.webkit.org/changeset/258180>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Timothy Hatcher]

*** Bug 203293 has been marked as a duplicate of this bug. ***

[Pedro Furtado]

In which version of iOS it will be available?

[Alex Christensen]

We can't comment on future releases, but what is your interest in this particular change?

[jcesarmobile]

People is probably interested in "WKWebView: audio tag sound stops when app goes to background on iOS 13", that has been marked as duplicate of this one, so I guess this change solves that problem too and it's not strange that a lot of people is waiting for it.

[Joe Moore]

The backgrounded webkit audio bug is definitely why I'm interested in this fix deployment, assuming that this fix does, in fact, fix the audio bug, too.

[Pedro Furtado]

I am in same situation, Joe. Waiting a release with this fix.

+1, this fix was referenced from https://bugs.webkit.org/show_bug.cgi?id=198277, which my users are very interested to see released.

[Chris Dumez]

This particular change shipped yesterday in iOS 13.5.1. If you can still reproduce it in 13.5.1, then your bug was mistakenly duped (and I suspect it was).

It looks like your suspicion was correct: this did not fix https://bugs.webkit.org/show_bug.cgi?id=198277

[Chris Dumez]

(In reply to brian+webkitbugzilla from comment #30)
> It looks like your suspicion was correct: this did not fix
> https://bugs.webkit.org/show_bug.cgi?id=198277

Waiting a bit to give others a chance to confirm. If everybody agrees the background audio bug is not fixed, I will un-dupe.

[Pedro Furtado]

Confirmed: not fixed yet. The bug still occurs.

Our app, and even a blank app that I created in a few minutes, not work with iOS 13.5.1.

Please, could you reopen this bug?

[Pedro Furtado]

Anyway, this bug also happens in iOS 13.5.1 :  203293 - WKWebView: audio tag sound stops when app goes to background on iOS 13 (https://bugs.webkit.org/show_bug.cgi?id=203293)

[Bernardo Oliveira]

(In reply to Chris Dumez from comment #31)
> (In reply to brian+webkitbugzilla from comment #30)
> > It looks like your suspicion was correct: this did not fix
> > https://bugs.webkit.org/show_bug.cgi?id=198277
> 
> Waiting a bit to give others a chance to confirm. If everybody agrees the
> background audio bug is not fixed, I will un-dupe.

Here I'm using the iOS 13.5.1 and audio stops playing when a standalone web app is no longer in the foreground or in lock screen.

[Chris Dumez]

(In reply to Bernardo Oliveira from comment #34)
> (In reply to Chris Dumez from comment #31)
> > (In reply to brian+webkitbugzilla from comment #30)
> > > It looks like your suspicion was correct: this did not fix
> > > https://bugs.webkit.org/show_bug.cgi?id=198277
> > 
> > Waiting a bit to give others a chance to confirm. If everybody agrees the
> > background audio bug is not fixed, I will un-dupe.
> 
> Here I'm using the iOS 13.5.1 and audio stops playing when a standalone web
> app is no longer in the foreground or in lock screen.

The bugs were already deduped.

Waiting for this fix for our PWA which has audio content

[Chris Dumez]

(In reply to alex7golovin from comment #36)
> Waiting for this fix for our PWA which has audio content

Then this is not the fix you're looking for.

(In reply to Chris Dumez from comment #37)
> (In reply to alex7golovin from comment #36)
> > Waiting for this fix for our PWA which has audio content
> 
> Then this is not the fix you're looking for.

Ahh.. all right, sorry

will wait for [another one](https://bugs.webkit.org/show_bug.cgi?id=198277) :)