Re-sync web-platform-tests/domparsing from upstream

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Pablo Saavedra]

Re-sync web-platform-tests/domparsing from upstream

[Pablo Saavedra]

Created attachment 386511 [details]
patch

[Pablo Saavedra]

Created attachment 386517 [details]
patch

[Pablo Saavedra]

Created attachment 386524 [details]
patch

[Carlos Alberto Lopez Perez]

Comment on attachment 386524 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386524&action=review

It looks there are some failures on the EWS with this last version of the patch.

> LayoutTests/imported/w3c/resources/import-expectations.json:159
>      "web-platform-tests/domparsing": "import", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", 
> -    "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", 
> -    "web-platform-tests/domparsing/innerhtml-02.html": "skip", 
> -    "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", 
> -    "web-platform-tests/domparsing/style_attribute_html.html": "skip", 
> +    "web-platform-tests/domparsing/": "import", 

I know this is tool-generated. But this added line looks like its not needed?
There is already a '"web-platform-tests/domparsing": "import",' line above

[Pablo Saavedra]

Created attachment 386665 [details]
patch

[Pablo Saavedra]

(In reply to Carlos Alberto Lopez Perez from comment #4)
> Comment on attachment 386524 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386524&action=review
> 
> It looks there are some failures on the EWS with this last version of the
> patch.
> 
> > LayoutTests/imported/w3c/resources/import-expectations.json:159
> >      "web-platform-tests/domparsing": "import", 
> > -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", 
> > -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", 
> > -    "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", 
> > -    "web-platform-tests/domparsing/innerhtml-02.html": "skip", 
> > -    "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", 
> > -    "web-platform-tests/domparsing/style_attribute_html.html": "skip", 
> > +    "web-platform-tests/domparsing/": "import", 
> 
> I know this is tool-generated. But this added line looks like its not needed?
> There is already a '"web-platform-tests/domparsing": "import",' line above

I see. This is fixed in the latest version of the patch.

... checking right now the errors show by the EWS.

[Pablo Saavedra]

This issue was surpassed by https://bugs.webkit.org/show_bug.cgi?id=205696.

[Pablo Saavedra]

Created attachment 386666 [details]
patch

[Pablo Saavedra]

Rebasing this patch in the top of the work done by Chris Dumez in https://bugs.webkit.org/show_bug.cgi?id=205696.  Only the update of the import-expectations.json file looks like missing. Let's wait for his opinion about if this last change is really necessary or not.

[Pablo Saavedra]

Created attachment 386667 [details]
patch

[Carlos Alberto Lopez Perez]

Comment on attachment 386667 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386667&action=review

> LayoutTests/imported/w3c/resources/import-expectations.json:159
>      "web-platform-tests/domparsing": "import", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", 
> -    "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", 
> -    "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", 
> -    "web-platform-tests/domparsing/innerhtml-02.html": "skip", 
> -    "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", 
> -    "web-platform-tests/domparsing/style_attribute_html.html": "skip", 
> +    "web-platform-tests/domparsing/": "import", 

In the end, after this patch, this would be:


"web-platform-tests/domparsing": "import", 
"web-platform-tests/domparsing/": "import", 


So I think the last line added is not needed, looks superfluous.

[Pablo Saavedra]

Created attachment 386937 [details]
patch

[Pablo Saavedra]

The fails in ios-wk2 and api-ios look like nothing to do respect the changes reported by this patch.

[WebKit Commit Bot]

Comment on attachment 386937 [details]
patch

Clearing flags on attachment: 386937

Committed r254128: <https://trac.webkit.org/changeset/254128>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58375157>