Bug 205638

Summary:

Re-sync web-platform-tests/domparsing from upstream

Product:

WebKit

Reporter:

Pablo Saavedra <psaavedra>

Component:

Tools / Tests

Assignee:

Pablo Saavedra <psaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, clopez, commit-queue, psaavedra, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none
patch	none
patch	none
patch	none
patch	none

Pablo Saavedra

Reported 2019-12-30 00:25:20 PST

Re-sync web-platform-tests/domparsing from upstream

Attachments
patch (12.51 KB, patch) 2019-12-30 00:27 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
patch (27.96 KB, patch) 2019-12-30 01:31 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
patch (37.12 KB, patch) 2019-12-30 05:03 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
patch (37.12 KB, patch) 2020-01-03 00:31 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
patch (1.94 KB, patch) 2020-01-03 00:52 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
patch (1.95 KB, patch) 2020-01-03 00:58 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
patch (1.90 KB, patch) 2020-01-06 23:41 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Pablo Saavedra

Comment 1 2019-12-30 00:27:25 PST

Created attachment 386511 [details] patch

Pablo Saavedra

Comment 2 2019-12-30 01:31:02 PST

Created attachment 386517 [details] patch

Pablo Saavedra

Comment 3 2019-12-30 05:03:12 PST

Created attachment 386524 [details] patch

Carlos Alberto Lopez Perez

Comment 4 2019-12-30 08:32:18 PST

Comment on attachment 386524 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=386524&action=review It looks there are some failures on the EWS with this last version of the patch. > LayoutTests/imported/w3c/resources/import-expectations.json:159 > "web-platform-tests/domparsing": "import", > - "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", > - "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", > - "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", > - "web-platform-tests/domparsing/innerhtml-02.html": "skip", > - "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", > - "web-platform-tests/domparsing/style_attribute_html.html": "skip", > + "web-platform-tests/domparsing/": "import", I know this is tool-generated. But this added line looks like its not needed? There is already a '"web-platform-tests/domparsing": "import",' line above

Pablo Saavedra

Comment 5 2020-01-03 00:31:22 PST

Created attachment 386665 [details] patch

Pablo Saavedra

Comment 6 2020-01-03 00:32:56 PST

(In reply to Carlos Alberto Lopez Perez from comment #4) > Comment on attachment 386524 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386524&action=review > > It looks there are some failures on the EWS with this last version of the > patch. > > > LayoutTests/imported/w3c/resources/import-expectations.json:159 > > "web-platform-tests/domparsing": "import", > > - "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", > > - "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", > > - "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", > > - "web-platform-tests/domparsing/innerhtml-02.html": "skip", > > - "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", > > - "web-platform-tests/domparsing/style_attribute_html.html": "skip", > > + "web-platform-tests/domparsing/": "import", > > I know this is tool-generated. But this added line looks like its not needed? > There is already a '"web-platform-tests/domparsing": "import",' line above I see. This is fixed in the latest version of the patch. ... checking right now the errors show by the EWS.

Pablo Saavedra

Comment 7 2020-01-03 00:48:31 PST

This issue was surpassed by https://bugs.webkit.org/show_bug.cgi?id=205696.

Pablo Saavedra

Comment 8 2020-01-03 00:52:35 PST

Created attachment 386666 [details] patch

Pablo Saavedra

Comment 9 2020-01-03 00:55:24 PST

Rebasing this patch in the top of the work done by Chris Dumez in https://bugs.webkit.org/show_bug.cgi?id=205696. Only the update of the import-expectations.json file looks like missing. Let's wait for his opinion about if this last change is really necessary or not.

Pablo Saavedra

Comment 10 2020-01-03 00:58:07 PST

Created attachment 386667 [details] patch

Carlos Alberto Lopez Perez

Comment 11 2020-01-03 07:51:57 PST

Comment on attachment 386667 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=386667&action=review > LayoutTests/imported/w3c/resources/import-expectations.json:159 > "web-platform-tests/domparsing": "import", > - "web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html": "skip", > - "web-platform-tests/domparsing/DOMParser-parseFromString-xml.html": "skip", > - "web-platform-tests/domparsing/XMLSerializer-serializeToString.html": "skip", > - "web-platform-tests/domparsing/innerhtml-02.html": "skip", > - "web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml": "skip", > - "web-platform-tests/domparsing/style_attribute_html.html": "skip", > + "web-platform-tests/domparsing/": "import", In the end, after this patch, this would be: "web-platform-tests/domparsing": "import", "web-platform-tests/domparsing/": "import", So I think the last line added is not needed, looks superfluous.

Pablo Saavedra

Comment 12 2020-01-06 23:41:52 PST

Created attachment 386937 [details] patch

Pablo Saavedra

Comment 13 2020-01-07 07:27:14 PST

The fails in ios-wk2 and api-ios look like nothing to do respect the changes reported by this patch.

WebKit Commit Bot

Comment 14 2020-01-07 08:31:16 PST

Comment on attachment 386937 [details] patch Clearing flags on attachment: 386937 Committed r254128: <https://trac.webkit.org/changeset/254128>

WebKit Commit Bot

Comment 15 2020-01-07 08:31:18 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 16 2020-01-07 08:32:12 PST

<rdar://problem/58375157>

Note You need to log in before you can comment on or make changes to this bug.