Bug 205636

Summary:

WebKit failed to build due to error C2143 on windows with MSVC

Product:

WebKit

Reporter:

QuellaZhang <1998zhangyi>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

Hironori.Fujii

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Windows 10

Attachments:

Description	Flags
log_x64_build	none

QuellaZhang

Reported 2019-12-29 23:29:56 PST

Created attachment 386510 [details] log_x64_build Environment: VS 2017 + Windows Server 2016 Issue description: We tried to build WebKit using VS2017 on Windows Server 2016. WebKit failed to build due to error C2143: syntax error: missing '}' before 'constant' (compiling source file D:\WebKit\src\Source\WebCore\platform\graphics\FormatConverter.cpp) on windows with MSVC. It can be reproduced on master branch 655e8a7 commit.Could you please help take a look at this? Thanks in advance! Repro steps: 1. git clone https://github.com/WebKit/webkit d:\WebKit\src 2. open a VS 2017 x64 command prompt as admin and browse to D:\Webkit 3. extra WebKitSupportLibrary\win to D:\WebKit\src\WebKitLibraries\win 4. extra WebKitAuxiliaryLibrary\win to D:\WebKit\src\WebKitLibraries\win 5. mkdir build_x64 && pushd build_x64 6. cmake -G "Visual Studio 15 2017 Win64" -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSHOW_BINDINGS_GENERATION_PROGRESS=1 -DDEVELOPER_MODE=ON -DENABLE_EXPERIMENTAL_FEATURES=ON -DCMAKE_SYSTEM_VERSION=10.0.17134.0 -DPORT="WinCairo" -DRUBY_LIBRARY=C:\Ruby25-x64\lib ..\src 7. msbuild /p:Configuration=Release;Platform=x64 WebKit.sln /t:Rebuild Actual result: D:\WebKit\src\Source\WebCore\platform\graphics\GraphicsContext3DBase.h(113): error C2143: syntax error: missing '}' before 'constant' (compiling source file D:\WebKit\src\Source\WebCore\platform\graphics\FormatConverter.cpp) [D:\WebKit\build_x64\Source\WebCore\WebCore.vcxproj] D:\WebKit\src\Source\WebCore\platform\graphics\GraphicsContext3DBase.h(113): error C2143: syntax error: missing '}' before 'constant' (compiling source file D:\WebKit\src\Source\WebCore\platform\graphics\GraphicsContext3D.cpp) [D:\WebKit\build_x64\Source\WebCore\WebCore.vcxproj]

Attachments
log_x64_build (694.49 KB, text/plain) 2019-12-29 23:29 PST, QuellaZhang	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2020-01-05 21:46:29 PST

Thank you for reporting. This issue should be solved by Bug 205743. *** This bug has been marked as a duplicate of bug 205743 ***

Note You need to log in before you can comment on or make changes to this bug.