| Summary: | WebKitCSSTransformValue.idl operation types don't match the implementation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
Created attachment 23061 [details]
Patch, testcase, changelog
Gonna remove this too:
// Note there are gaps because the proposed specification
// has other types that are not implemented yet
Comment on attachment 23061 [details]
Patch, testcase, changelog
Please do scaleX and not scalex to match the spec (same for the other ops).
Created attachment 23062 [details]
Fixed patch, testcase
Comment on attachment 23062 [details]
Fixed patch, testcase
r=me
Committed r35983 M WebCore/bindings/js/JSCSSValueCustom.cpp M WebCore/ChangeLog M WebCore/css/CSSValue.h M WebCore/css/WebKitCSSTransformValue.h M WebCore/css/WebKitCSSTransformValue.idl M WebCore/css/WebKitCSSTransformValue.cpp M LayoutTests/ChangeLog A LayoutTests/css3/transform-value-types-expected.txt A LayoutTests/css3/transform-value-types.html r35983 = 8f30d02092e53e5ffb672f82d88b04e0ad86cdbc (trunk) |
WebKitCSSTransformValue has a number of issues: 1. the OperationType consts don't match the implementation 2. The order of operations is weird (tho it does need to match the spec) 3. getPropertyCSSValue('-webkit-transform') doesn't return a WebKitCSSTransformValue, but a CSSValueList