Bug 205604

Summary:

[WebGL] Add a pure virtual base class for GraphicsContext3D

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, annulen, cdumez, cmarcelo, darin, don.olmstead, esprehn+autocc, ews-watchlist, fujii, graouts, gyuyoung.kim, kondapallykalyan, luiz, noam, ross.kirsling, ryuan.choi, sam, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

205648

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	sam: review+

Dean Jackson

Reported 2019-12-27 02:08:25 PST

[WebGL] Add a pure virtual base class for GraphicsContext3D

Attachments
Patch (338.29 KB, patch) 2019-12-27 02:22 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (369.03 KB, patch) 2019-12-27 12:24 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (371.75 KB, patch) 2019-12-27 13:40 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (373.67 KB, patch) 2019-12-27 14:05 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (375.77 KB, patch) 2019-12-27 14:29 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (376.76 KB, patch) 2019-12-27 16:18 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (377.08 KB, patch) 2019-12-28 12:09 PST, Dean Jackson	sam: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2019-12-27 02:22:59 PST

Created attachment 386436 [details] Patch

Sam Weinig

Comment 2 2019-12-27 12:03:13 PST

I think this would be easier to process if you split the enum renaming into its own change first. Also, can you remind me, is GraphicsContext3D a generic 3D context that is used for both WebGL and WebGPU? If it's not really generic to anything but an OpenGL/OpenGLES/ANGLE backend, perhaps we should take this opportunity to rename it?

Dean Jackson

Comment 3 2019-12-27 12:24:31 PST

Created attachment 386451 [details] Patch

Dean Jackson

Comment 4 2019-12-27 13:29:28 PST

(In reply to Sam Weinig from comment #2) > I think this would be easier to process if you split the enum renaming into > its own change first. Agreed (although now extra work!) > > Also, can you remind me, is GraphicsContext3D a generic 3D context that is > used for both WebGL and WebGPU? If it's not really generic to anything but > an OpenGL/OpenGLES/ANGLE backend, perhaps we should take this opportunity to > rename it? It is just for GLES/WebGL-like things, so maybe it should be called GraphicsContextGL?

Dean Jackson

Comment 5 2019-12-27 13:40:26 PST

Created attachment 386454 [details] Patch

Dean Jackson

Comment 6 2019-12-27 14:05:17 PST

Created attachment 386456 [details] Patch

Dean Jackson

Comment 7 2019-12-27 14:29:48 PST

Created attachment 386457 [details] Patch

Dean Jackson

Comment 8 2019-12-27 16:18:13 PST

Created attachment 386458 [details] Patch