Bug 205572

Summary: Web Inspector: Color picker: make it keyboard accessible
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+, bburg: commit-queue-
Pach none

Nikita Vasilyev
Reported 2019-12-23 15:43:59 PST
For the Color Square, up/down/left/right keys should move the "crosshair". For the hue and opacity sliders: - Pressing up and down keys should adjust the value by 1%. - When holding Shift, up and down keys adjust the value by 10%.
Attachments
Patch (7.46 KB, patch)
2019-12-23 15:52 PST, Nikita Vasilyev 		bburg: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
Pach (8.07 KB, patch)
2020-01-06 13:51 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-23 15:44:18 PST
<rdar://problem/58169943>
Nikita Vasilyev
Comment 2 2019-12-23 15:52:50 PST
Created attachment 386363 [details] Patch
Blaze Burg
Comment 3 2020-01-06 10:56:59 PST
Comment on attachment 386363 [details] Patch r=me, with one issue. Whenever I use arrows, I get the Bonking noise (InspectorFrontendHost.beep()?) that happens when the default event handler runs. So I think you need to call .preventDefault() on the event after handling it.
Nikita Vasilyev
Comment 4 2020-01-06 13:51:21 PST
Created attachment 386882 [details] Pach
WebKit Commit Bot
Comment 5 2020-01-06 15:55:42 PST
Comment on attachment 386882 [details] Pach Clearing flags on attachment: 386882 Committed r254094: <https://trac.webkit.org/changeset/254094>
WebKit Commit Bot
Comment 6 2020-01-06 15:55:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.