Bug 205570

Summary:

REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	nvasilyev: review-, nvasilyev: commit-queue-
Patch	none

Nikita Vasilyev

Reported 2019-12-23 15:36:20 PST

There's relevant code in Popover.js but it doesn't work: handleEvent(event) { switch (event.type) { ... case "keypress": if (event.keyCode === WI.KeyboardShortcut.Key.Escape.keyCode) this.dismiss();

Attachments
Patch (1.48 KB, patch) 2019-12-24 17:35 PST, Nikita Vasilyev	nvasilyev: review- nvasilyev: commit-queue-	Details Formatted Diff Diff
Patch (2.33 KB, patch) 2020-01-03 18:41 PST, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.