Bug 205539

Summary: Deprecate _WKWebsitePolicies
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2019-12-21 00:11:54 PST
Deprecate _WKWebsitePolicies
Attachments
Patch (38.57 KB, patch)
2019-12-21 00:14 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (38.62 KB, patch)
2020-01-02 11:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (38.62 KB, patch)
2020-01-02 17:38 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-12-21 00:14:35 PST
Created attachment 386292 [details] Patch
Alex Christensen
Comment 2 2020-01-02 11:40:56 PST
Created attachment 386610 [details] Patch
Alex Christensen
Comment 3 2020-01-02 17:38:27 PST
Created attachment 386650 [details] Patch
Wenson Hsieh
Comment 4 2020-01-03 08:50:30 PST
Comment on attachment 386650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review Nice! > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145 > - [self _updateWebpagePreferences:websitePolicies.webpagePreferences]; Is this change binary compatible with shipping Safari?
Alex Christensen
Comment 5 2020-01-03 08:52:52 PST
Comment on attachment 386650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145 >> - [self _updateWebpagePreferences:websitePolicies.webpagePreferences]; > > Is this change binary compatible with shipping Safari? This will break a small edge-case feature in shipping Safari when using open source WebKit with it, but this is not important to open source WebKit developers.
WebKit Commit Bot
Comment 6 2020-01-03 09:49:58 PST
The commit-queue encountered the following flaky tests while processing attachment 386650 [details]: highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com) imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html bug 205728 (author: aboya@igalia.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-01-03 09:50:51 PST
Comment on attachment 386650 [details] Patch Clearing flags on attachment: 386650 Committed r254005: <https://trac.webkit.org/changeset/254005>
WebKit Commit Bot
Comment 8 2020-01-03 09:50:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-03 09:51:18 PST
<rdar://problem/58299901>
Note You need to log in before you can comment on or make changes to this bug.