Summary: | Deprecate _WKWebsitePolicies | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alex Christensen
2019-12-21 00:11:54 PST
Created attachment 386292 [details]
Patch
Created attachment 386610 [details]
Patch
Created attachment 386650 [details]
Patch
Comment on attachment 386650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review Nice! > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145 > - [self _updateWebpagePreferences:websitePolicies.webpagePreferences]; Is this change binary compatible with shipping Safari? Comment on attachment 386650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145 >> - [self _updateWebpagePreferences:websitePolicies.webpagePreferences]; > > Is this change binary compatible with shipping Safari? This will break a small edge-case feature in shipping Safari when using open source WebKit with it, but this is not important to open source WebKit developers. The commit-queue encountered the following flaky tests while processing attachment 386650 [details]: highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com) imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html bug 205728 (author: aboya@igalia.com) The commit-queue is continuing to process your patch. Comment on attachment 386650 [details] Patch Clearing flags on attachment: 386650 Committed r254005: <https://trac.webkit.org/changeset/254005> All reviewed patches have been landed. Closing bug. |