Bug 205539

Summary: Deprecate _WKWebsitePolicies
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2019-12-21 00:11:54 PST
Deprecate _WKWebsitePolicies
Comment 1 Alex Christensen 2019-12-21 00:14:35 PST
Created attachment 386292 [details]
Patch
Comment 2 Alex Christensen 2020-01-02 11:40:56 PST
Created attachment 386610 [details]
Patch
Comment 3 Alex Christensen 2020-01-02 17:38:27 PST
Created attachment 386650 [details]
Patch
Comment 4 Wenson Hsieh 2020-01-03 08:50:30 PST
Comment on attachment 386650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review

Nice!

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145
> -    [self _updateWebpagePreferences:websitePolicies.webpagePreferences];

Is this change binary compatible with shipping Safari?
Comment 5 Alex Christensen 2020-01-03 08:52:52 PST
Comment on attachment 386650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386650&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2145
>> -    [self _updateWebpagePreferences:websitePolicies.webpagePreferences];
> 
> Is this change binary compatible with shipping Safari?

This will break a small edge-case feature in shipping Safari when using open source WebKit with it, but this is not important to open source WebKit developers.
Comment 6 WebKit Commit Bot 2020-01-03 09:49:58 PST
The commit-queue encountered the following flaky tests while processing attachment 386650 [details]:

highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com)
imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html bug 205728 (author: aboya@igalia.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-03 09:50:51 PST
Comment on attachment 386650 [details]
Patch

Clearing flags on attachment: 386650

Committed r254005: <https://trac.webkit.org/changeset/254005>
Comment 8 WebKit Commit Bot 2020-01-03 09:50:53 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-03 09:51:18 PST
<rdar://problem/58299901>