Bug 205528

Summary: LegacyInlineTextBox::selectionState accessor mutates ellipsis selection state
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205318    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Megan Gardner
Reported 2019-12-20 16:22:42 PST
The code that deals with ellipsis and selections is in a place that sounds like it should not be mutating state, but it is. This should likely move to SelectionRangeData. Move this code, and also make sure that it also works with the new HighlightAPI.
Attachments
Patch (10.23 KB, patch)
2021-09-13 03:51 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-12-20 16:23:30 PST
<rdar://problem/58125978>
Antti Koivisto
Comment 2 2021-09-13 03:51:37 PDT
Created attachment 438026 [details] Patch
EWS
Comment 3 2021-09-13 10:48:03 PDT
Committed r282337 (241604@main): <https://commits.webkit.org/241604@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438026 [details].
Radar WebKit Bug Importer
Comment 4 2021-09-13 10:49:24 PDT
<rdar://problem/83062849>
Note You need to log in before you can comment on or make changes to this bug.