| Summary: | CSSRule.idl missing keyframe-related RuleTypes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
Created attachment 23046 [details]
Patch, testcase, changelog
Comment on attachment 23046 [details]
Patch, testcase, changelog
This really should be using the newer js-style tests, which have "shouldBe" functions provided for you to produce nice "PASS" "FAIL" output for subtests like this. I would encourage you to look at the tests in fast/js or ask ggaren for more infos. make-js-test-wrappers is part of that whole system and turns the .js files + resources/TEMPLATE.html into the resuling browser-runnable test files.
Change looks fine though.
Committed, with make-js-test-wrapper based test: Committed r35972 M WebCore/ChangeLog M WebCore/css/CSSRule.idl M LayoutTests/ChangeLog A LayoutTests/animations/animation-css-rule-types.html A LayoutTests/animations/animation-css-rule-types-expected.txt A LayoutTests/animations/resources/animation-css-rule-types.js A LayoutTests/animations/resources/TEMPLATE.html r35972 = ae77c41c078d3a1cf4ecfe7f174226da32f87712 (trunk) This change broke fast/dom/Window/window-properties.html, which I shall fix. Created attachment 23060 [details]
Fixed fast/dom/Window/window-properties-expected.txt
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/dom/Window/window-properties-expected.txt Committed r35980 |
CSSRule.idl is missing the keyframe-related rule types: const unsigned short WEBKIT_KEYFRAMES_RULE = 8; const unsigned short WEBKIT_KEYFRAME_RULE = 9;