Bug 20552 – CSSRule.idl missing keyframe-related RuleTypes

• Component: CSS
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

CSSRule.idl is missing the keyframe-related rule types:

        const unsigned short WEBKIT_KEYFRAMES_RULE = 8;
        const unsigned short WEBKIT_KEYFRAME_RULE = 9;

[Simon Fraser (smfr)]

Created attachment 23046 [details]
Patch, testcase, changelog

[Eric Seidel (no email)]

Comment on attachment 23046 [details]
Patch, testcase, changelog

This really should be using the newer js-style tests, which have "shouldBe" functions provided for you to produce nice "PASS" "FAIL" output for subtests like this.  I would encourage you to look at the tests in fast/js or ask ggaren for more infos.   make-js-test-wrappers is part of that whole system and turns the .js files + resources/TEMPLATE.html into the resuling browser-runnable test files.

Change looks fine though.

[Simon Fraser (smfr)]

Committed, with make-js-test-wrapper based test:

Committed r35972
	M	WebCore/ChangeLog
	M	WebCore/css/CSSRule.idl
	M	LayoutTests/ChangeLog
	A	LayoutTests/animations/animation-css-rule-types.html
	A	LayoutTests/animations/animation-css-rule-types-expected.txt
	A	LayoutTests/animations/resources/animation-css-rule-types.js
	A	LayoutTests/animations/resources/TEMPLATE.html
r35972 = ae77c41c078d3a1cf4ecfe7f174226da32f87712 (trunk)

[Simon Fraser (smfr)]

This change broke fast/dom/Window/window-properties.html, which I shall fix.

[Simon Fraser (smfr)]

Created attachment 23060 [details]
Fixed fast/dom/Window/window-properties-expected.txt

[Simon Fraser (smfr)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/dom/Window/window-properties-expected.txt
Committed r35980