Bug 205513

Summary: lldbwebkittester: Strip CLANG_DEBUG_INFORMATION_LEVEL option while building
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, ews-watchlist, slewis, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-12-20 11:56:15 PST
When built with CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only, our lldb tests don't work. We should disable these tests on release queues.
Attachments
Patch (1.38 KB, patch)
2019-12-20 12:58 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.51 KB, patch)
2019-12-20 13:46 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-12-20 12:37:25 PST
Talking with Alexey, we're going to the opposite: we're going to fix release binaries so they can run lldb tests instead.
Jonathan Bedard
Comment 2 2019-12-20 12:58:46 PST
Created attachment 386242 [details] Patch
Alexey Proskuryakov
Comment 3 2019-12-20 13:37:13 PST
Comment on attachment 386242 [details] Patch Worth explaining this in a comment. We are lucky that fixing “make” builds is not necessary at the moment.
Jonathan Bedard
Comment 4 2019-12-20 13:46:52 PST
Created attachment 386246 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-12-20 14:30:40 PST
Comment on attachment 386246 [details] Patch for landing Clearing flags on attachment: 386246 Committed r253845: <https://trac.webkit.org/changeset/253845>
WebKit Commit Bot
Comment 6 2019-12-20 14:30:42 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-20 14:31:30 PST
<rdar://problem/58125695>
Note You need to log in before you can comment on or make changes to this bug.