Bug 205511

Summary: [Media in GPU process] Get audio playing
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 205123    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Eric Carlson
Reported 2019-12-20 11:18:00 PST
Get audio playing in GPU process
Attachments
Patch (53.98 KB, patch)
2019-12-20 14:23 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (55.21 KB, patch)
2019-12-20 14:42 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (51.61 KB, patch)
2019-12-20 15:19 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (55.94 KB, patch)
2019-12-20 15:28 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-20 11:18:18 PST
<rdar://problem/58120354>
Eric Carlson
Comment 2 2019-12-20 14:23:23 PST
Created attachment 386254 [details] Patch
Eric Carlson
Comment 3 2019-12-20 14:42:59 PST
Created attachment 386260 [details] Patch
Jer Noble
Comment 4 2019-12-20 14:51:17 PST
Comment on attachment 386260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386260&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:888 > -#if HAVE(AVFOUNDATION_LOADER_DELEGATE) > +#if HAVE(AVFOUNDATION_LOADER_DELEGATE) && 0 ?
Eric Carlson
Comment 5 2019-12-20 15:19:50 PST
Created attachment 386266 [details] Patch for landing
Eric Carlson
Comment 6 2019-12-20 15:28:37 PST
Created attachment 386269 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-12-20 23:35:52 PST
Comment on attachment 386269 [details] Patch for landing Clearing flags on attachment: 386269 Committed r253861: <https://trac.webkit.org/changeset/253861>
WebKit Commit Bot
Comment 8 2019-12-20 23:35:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.