Bug 205510

Summary: Share code for computing the absolute positioned line boxes for a range
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
To Land none

Daniel Bates
Reported 2019-12-20 11:07:34 PST
RenderTextLineBoxes::absoluteRectsForRange() and RenderTextLineBoxes::absoluteQuadsForRange() have almost identical implementations. We should share more code
Attachments
Patch (5.02 KB, patch)
2019-12-20 11:14 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (6.12 KB, patch)
2019-12-20 11:37 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-12-20 11:14:42 PST
Created attachment 386228 [details] Patch
Daniel Bates
Comment 2 2019-12-20 11:20:32 PST
Thank you!
Daniel Bates
Comment 3 2019-12-20 11:37:55 PST
Created attachment 386232 [details] To Land
Daniel Bates
Comment 4 2019-12-20 11:40:43 PST
Comment on attachment 386232 [details] To Land Clearing flags on attachment: 386232 Committed r253833: <https://trac.webkit.org/changeset/253833>
Daniel Bates
Comment 5 2019-12-20 11:40:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-20 11:41:15 PST
<rdar://problem/58121065>
Note You need to log in before you can comment on or make changes to this bug.