Bug 205510 - Share code for computing the absolute positioned line boxes for a range
Summary: Share code for computing the absolute positioned line boxes for a range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-20 11:07 PST by Daniel Bates
Modified: 2019-12-20 11:41 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2019-12-20 11:14 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (6.12 KB, patch)
2019-12-20 11:37 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-12-20 11:07:34 PST 
RenderTextLineBoxes::absoluteRectsForRange() and RenderTextLineBoxes::absoluteQuadsForRange() have almost identical implementations. We should share more code
Comment 1 Daniel Bates 2019-12-20 11:14:42 PST 
Created attachment 386228 [details]
Patch
Comment 2 Daniel Bates 2019-12-20 11:20:32 PST 
Thank you!
Comment 3 Daniel Bates 2019-12-20 11:37:55 PST 
Created attachment 386232 [details]
To Land
Comment 4 Daniel Bates 2019-12-20 11:40:43 PST 
Comment on attachment 386232 [details]
To Land

Clearing flags on attachment: 386232

Committed r253833: <https://trac.webkit.org/changeset/253833>
Comment 5 Daniel Bates 2019-12-20 11:40:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-20 11:41:15 PST 
<rdar://problem/58121065>